Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Feb 4, 2021

Actually fix google/honggfuzz#336 (comment)

Follow-up to #20065

Steps to test: honggfuzz section in doc/fuzzing.md

@maflcko
Copy link
Member Author

maflcko commented Feb 4, 2021

On master:

  • Incorrectly compiles with -DPROVIDE_MAIN_FUNCTION
  • Thus, the persistent fuzz config fails:
# FUZZ=process_message_version  ./honggfuzz/honggfuzz -i ./qa-assets/fuzz_seed_corpus/process_message_version -- ./src/test/fuzz/fuzz 
[2021-02-04T13:19:41+0100][E][72620] cmdlineVerify():242 You must specify '___FILE___' if the -s (stdin fuzzing) or --persistent options are not set
[2021-02-04T13:19:41+0100][F][72620] main():325 Parsing of the cmd-line arguments failed

It is only possible to run the extremely slow -s (stdin) fuzz config:

# FUZZ=process_message_version  ./honggfuzz/honggfuzz -s -i ./qa-assets/fuzz_seed_corpus/process_message_version -- ./src/test/fuzz/fuzz
...
       Speed : 0/sec [avg: 13]
...

On this pull:

# FUZZ=process_message_version  ./honggfuzz/honggfuzz -i ./qa-assets/fuzz_seed_corpus/process_message_version -- ./src/test/fuzz/fuzz
...
       Speed : 13,184/sec [avg: 12,328]
...

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 4, 2021

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift
Copy link
Contributor

cr ACK fac4be3: patch looks correct!

Thanks for fixing.

@maflcko maflcko merged commit 01d2cf2 into bitcoin:master Feb 5, 2021
@maflcko maflcko deleted the 2101-fuzzTake2 branch February 5, 2021 09:11
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 5, 2021
fac4be3 fuzz: Configure check for main function (take 2) (MarcoFalke)

Pull request description:

  Actually fix google/honggfuzz#336 (comment)

  Follow-up to bitcoin#20065

  Steps to test: `honggfuzz` section in doc/fuzzing.md

ACKs for top commit:
  practicalswift:
    cr ACK fac4be3: patch looks correct!

Tree-SHA512: 893768c80439fe5d90b883ade89dc02f5bb80e27637916cf5575b6a9ed0b1c04942ff851342f5bbabb8666e6696715427feeb98f5301ad23c7b87b09e5872f97
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 6, 2022
fac4be3 fuzz: Configure check for main function (take 2) (MarcoFalke)

Pull request description:

  Actually fix google/honggfuzz#336 (comment)

  Follow-up to bitcoin#20065

  Steps to test: `honggfuzz` section in doc/fuzzing.md

ACKs for top commit:
  practicalswift:
    cr ACK fac4be3: patch looks correct!

Tree-SHA512: 893768c80439fe5d90b883ade89dc02f5bb80e27637916cf5575b6a9ed0b1c04942ff851342f5bbabb8666e6696715427feeb98f5301ad23c7b87b09e5872f97
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error message "LLVMFuzzerTestOneInput is not defined" also when LLVMFuzzerTestOneInput is defined?

4 participants