Skip to content

Add release notes for listdescriptors RPC #21049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Feb 4, 2021
Merged

Add release notes for listdescriptors RPC #21049

maflcko merged 1 commit into from
Feb 4, 2021

Conversation

@S3RK
Copy link
Contributor

@S3RK S3RK commented Feb 1, 2021

Original PR is #20226

@S3RK
Copy link
Contributor Author

S3RK commented Feb 1, 2021

cc @jonatack

@fanquake fanquake added the Docs label Feb 1, 2021
@laanwj
Copy link
Member

laanwj commented Feb 1, 2021

ACK 1ac5bc03c6d385cdc62e1d3560dfbcf3fed4d3f5

jonatack
jonatack reviewed Feb 1, 2021
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions below. Do you plan to address #20226 (comment)?

@S3RK
Copy link
Contributor Author

S3RK commented Feb 2, 2021

I tried so hard and got so far
But in the end there were still a few minor suggestions...

Thanks jonatack, hope one day I'll get my articles right 😄

Do you plan to address #20226 (comment)?

Done — #21063

@jonatack
Copy link
Member

jonatack commented Feb 2, 2021

ACK 51f3752

Thanks for updating. No worries :)

jonasschnelli
jonasschnelli approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 51f3752

@maflcko maflcko merged commit 5a429d3 into bitcoin:master Feb 4, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 4, 2021
Merge bitcoin#21049: Add release notes for listdescriptors RPC
0abaa33 
51f3752 Add release notes for listdescriptors RPC (Ivan Metlushko)

Pull request description:

  Original PR is bitcoin#20226

ACKs for top commit:
  jonatack:
    ACK 51f3752
  jonasschnelli:
    ACK 51f3752

Tree-SHA512: e8091d01b99a3effcd6c1738e7363a44858ba9bcf6bd99bf60f2025a25db83fc8d61354ab2002365b56071b9f3693c7d534153a259b5ebc91cbcf8d13f6555f1
@S3RK S3RK deleted the patch-1 branch March 1, 2021 07:28
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jonatack jonatack jonatack left review comments

@jonasschnelli jonasschnelli jonasschnelli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@S3RK @laanwj @jonatack @jonasschnelli @fanquake @maflcko