Skip to content

Conversation

@nolim1t
Copy link

@nolim1t nolim1t commented Jan 18, 2021

Add the the text from the release notes to the actual documentation docs/tor.md to document how users can preserve their old address.

Just in case users would like for some reason to preserve their existing v2 address with a not recommended text.

@fanquake fanquake added the Docs label Jan 18, 2021
@jonatack
Copy link
Member

Thanks @nolim1t. Unless this change is backported to 0.21.1, by the time 22.0 (the next release) is out tor v2 will be EOL, so maybe the existing release notes are enough. It may be good to squash your commits down to one when you are finished.

@nolim1t nolim1t force-pushed the tor-controlport-docs branch from 25d798f to 7e08a1b Compare January 18, 2021 10:31
@nolim1t
Copy link
Author

nolim1t commented Jan 18, 2021

Thanks @nolim1t. Unless this change is backported to 0.21.1, by the time 22.0 (the next release) is out tor v2 will be EOL, so maybe the existing release notes are enough. It may be good to squash your commits down to one when you are finished.

Squashed into one. Yep I recognize that it may be deprecated too, hence not recommended mention

@laanwj
Copy link
Member

laanwj commented Jan 18, 2021

We're on the trailing edge of TorV2 support here, and this is a really hacky workaround. I too think that the mention in the release notes is enough. No strong objection though.

Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept 0 on this, I think there's no need to mention this as it is will be mandatory to migrate to torv3 since support for v2 addresses will be disabled on the network, see Tor Deprecation Timeline

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@laanwj
Copy link
Member

laanwj commented Jan 27, 2021

I'm going to close this, sorry. Everyone is at most ~0 on this, which makes it unlikely that this will be merged. It doesn't seem worth the hassle to rebase .

@laanwj laanwj closed this Jan 27, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants