rpc: Remove deprecated bumpfee behavior #20891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Jan 8, 2021
achow101
force-pushed
the
rm-bumpfee-deprecated
branch
from
8c39369 to
2bfdf76
Compare
jonatack
reviewed
Jan 8, 2021
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
utACK, modulo test suggestion
achow101
force-pushed
the
rm-bumpfee-deprecated
branch
from
2bfdf76 to
ea0a7ec
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jan 9, 2021
This comment has been minimized.
This comment has been minimized.
hendeyk
approved these changes
Jan 11, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 20, 2021
fanquake
added a commit
that referenced
this pull request
Apr 1, 2021
1111896 doc: Merge release notes (MarcoFalke) faeba98 rpc: Missing doc updates for bumpfee psbt update (MarcoFalke) Pull request description: Stuff missed in #20891. Also merge release notes, so that it doesn't have to be done later. ACKs for top commit: fanquake: ACK 1111896 Tree-SHA512: c9be5a3c944e2981c83546c4761277f1ad5fb9ba97bec80d073db4229924cb48fd23cb5638217c844e05af51d80507718dd201099cbe50819986b3c47c5df7e5
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 25, 2021
4f504f8 rpc: fix code comment for bumpfee/psbtbumpfee output (Jon Atack) 5cb7ac2 rpc: fix docs for bumpfee psbt update (Jon Atack) Pull request description: Follow-up to bitcoin#21544 and bitcoin#20891 for the `bumpfee_helper` used for RPCs bumpfee and psbtbumpfee: - "psbt" field is only returned in psbtbumpfee and not bumpfee - bumpfee raises if private keys are disabled, so the txid help "Only returned when wallet private keys are enabled." no longer makes sense; remove it - add missing space in RPC examples ("Bump the fee, get the new transaction'stxid") - update txid/psbt code comments ACKs for top commit: klementtan: ACK [`4f504f8`](bitcoin@4f504f8) Tree-SHA512: 194faf8af52383eb8ac5cd22825265931bcde135dac79d8ecc4f84f698070da9b9373c00eef8623961881bb293157c7c9a0d71d1bcccf481ae3605a2d1444ed8
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 25, 2021
4f504f8 rpc: fix code comment for bumpfee/psbtbumpfee output (Jon Atack) 5cb7ac2 rpc: fix docs for bumpfee psbt update (Jon Atack) Pull request description: Follow-up to bitcoin#21544 and bitcoin#20891 for the `bumpfee_helper` used for RPCs bumpfee and psbtbumpfee: - "psbt" field is only returned in psbtbumpfee and not bumpfee - bumpfee raises if private keys are disabled, so the txid help "Only returned when wallet private keys are enabled." no longer makes sense; remove it - add missing space in RPC examples ("Bump the fee, get the new transaction'stxid") - update txid/psbt code comments ACKs for top commit: klementtan: ACK [`4f504f8`](bitcoin@4f504f8) Tree-SHA512: 194faf8af52383eb8ac5cd22825265931bcde135dac79d8ecc4f84f698070da9b9373c00eef8623961881bb293157c7c9a0d71d1bcccf481ae3605a2d1444ed8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the deprecation message, behavior, and test.
This was marked for removal in 22.0.