Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Jan 8, 2021

@hebasto hebasto force-pushed the 210108-deploy branch 2 times, most recently from cfb0884 to aaa7b29 Compare January 8, 2021 22:12
@DrahtBot DrahtBot added the Docs label Jan 8, 2021
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK aaa7b29

Confirming that without installing argparse, ds_store, mac_alias, make deploy fails on macOS Big Sur 11.1.

Deploying DMG is successful after installing these packages with pip3.

This change is required on macOS 11 Big Sur.
@hebasto
Copy link
Member Author

hebasto commented Jan 9, 2021

Updated aaa7b29 -> 3e61b8c (pr20890.02 -> pr20890.03, diff):

argparse is part of the Python standard library. It doesn't need installing.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3e61b8c

This change is required on macOS 11 Big Sur:

There's nothing macOS 11 specific about this doc addition. The same dependencies & dmg creation process is used you run make deploy on macOS 10.

@fanquake fanquake merged commit 708ef44 into bitcoin:master Jan 10, 2021
@hebasto hebasto deleted the 210108-deploy branch January 10, 2021 10:07
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 10, 2021
…nstall step

3e61b8c doc: Add explicit macdeployqtplus dependencies install step (Hennadii Stepanov)

Pull request description:

  This PR adds to macOS docs an explicit step to install `macdeployqtplus` script dependencies that are not part of the [Python Standard Library](https://docs.python.org/3/library/index.html):
  - https://pypi.org/project/ds-store/
  - https://pypi.org/project/mac-alias/

  This change is required on macOS 11 Big Sur:

  -  bitcoin#20371
  - bitcoin#20878

  Close bitcoin#20878.

ACKs for top commit:
  fanquake:
    ACK 3e61b8c

Tree-SHA512: d177139ee142d47cb27ad878d721cafcd03403ef861965ff532d712da461416380ec5878f70accf223a552a1f1e65eedb1e0ad72cb7a96791f8a55536ce28645
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request Jun 11, 2021
a68c7d5 depends: mac_alias 2.2.0 (fanquake)
d8e2baf doc: Add explicit macdeployqtplus dependencies install step (Hennadii Stepanov)
013305d macdeploy: use Python 3.6 (fanquake)
faf77c3 macdeploy: remove runHDIUtil in favor of directly calling subprocess.run (fanquake)
8bcfd58 macdeploy: remove existing PIVX-Core.dmg if present (fanquake)
023d3ca macdeploy: move qt_conf to where it's used (fanquake)
7cdb5bb macdeploy: consolidate .DS_Store generation (fanquake)
4da04d7 macdeploy: assume plistlib is available (fanquake)
56ab77a macdeploy: have a single level of logging output (fanquake)
d111cdf macdeploy: remove add-resources argument (fanquake)
4312410 macdeploy: remove codesigning argument (fanquake)
c2ee635 build: automatically determine macOS translations (fanquake)
1c44ecf scripts: filter more qt plugins we don't use in macdeployqtplus (fanquake)
c854f78 scripts: misc cleanups in macdeployqtplus (fanquake)
a3873ea scripts: use format() in macdeployqtplus (fanquake)
a65bea5 scripts: add type annotations to macdeployqtplus (fanquake)
ba179e5 build: Drop macports support (Ben Woosley)

Pull request description:

  This is a companion to #2272 that focuses on on the `.dmg` creation aspect of macOS builds (ie, `make deploy`). The following upstream PRs are backported here:
   - bitcoin#15175
   - bitcoin#16477
   - bitcoin#20422
   - bitcoin#20890
   - bitcoin#21658

  Also worth mentioning: This drops support for MacPorts entirely, which has been antiquated and un-maintained for quite some time, and never actually used by any PIVX macOS build doc.

ACKs for top commit:
  furszy:
    Tested using depends, ACK a68c7d5.
  random-zebra:
    utACK a68c7d5 and merging...

Tree-SHA512: 3e9fa81a905ca3e90f07ff1213ec69dd1220a19a6a215f256ab67f2594476dc95e8fe88f15a1c9f3314b1757a7a2e5d8e6d7a790d85c117bf4236a3833757430
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: make deploy fails on macOS Big Sur 11.1

4 participants