Skip to content

scripted-diff: Bump copyright headers #20813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Dec 31, 2020
Merged

scripted-diff: Bump copyright headers #20813

maflcko merged 1 commit into from
Dec 31, 2020

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Dec 31, 2020

Needs to be done because no one has removed the years yet

scripted-diff: Bump copyright headers
fa0074e 
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
@maflcko maflcko added the Docs label Dec 31, 2020
@practicalswift
Copy link
Contributor

practicalswift commented Dec 31, 2020

ACK fa0074e

@maflcko
Copy link
Member Author

maflcko commented Dec 31, 2020

Link to lint: https://cirrus-ci.com/task/5664588576325632?command=lint#L860

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 31, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko maflcko merged commit 4a54068 into bitcoin:master Dec 31, 2020
@maflcko maflcko deleted the 2012-bye2020 branch December 31, 2020 17:54
@michaelfolkson
Copy link

michaelfolkson commented Dec 31, 2020 •
edited
Loading

You want years entirely removed from all currently used copyright headers so they don't need to be updated next year @MarcoFalke? A good first issue?

@prusnak
Copy link
Contributor

prusnak commented Dec 31, 2020

Shouldn't the year be 2021 in this PR?

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 31, 2020
Merge bitcoin#20813: scripted-diff: Bump copyright headers
b876794
@kallewoof
Copy link
Contributor

kallewoof commented Jan 1, 2021

Yes, should be 2021...

@sipa
Copy link
Member

sipa commented Jan 1, 2021

No, none of these files have been touched in the year 2021 yet.

@kallewoof
Copy link
Contributor

kallewoof commented Jan 1, 2021

Some of them haven't been touched in 2020 either. I assumed the bump was for all files, regardless of whether we touched them or not.

@maflcko
Copy link
Member Author

maflcko commented Jan 1, 2021

The script will update the number in each file to be the year in the author date.

I am checking that the script works correctly, so if any update happened without a corresponding edit in 2020, please let me know.

@kallewoof
Copy link
Contributor

kallewoof commented Jan 1, 2021 •
edited
Loading

Edit: I've confused myself, I think. The idea is to set the copyright to the year at year-end for anything that changed that year. Bloody confusing, but I understand the point now, thanks.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@maflcko @practicalswift @DrahtBot @michaelfolkson @prusnak @kallewoof @sipa