doc: Update URLs to HTTPS where necessary #20810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Dec 31, 2020
|
|
||
| # ABI version | ||
| # http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html | ||
| # https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html |
Member
There was a problem hiding this comment.
This is a subtree that needs to be updated upstream
maflcko
reviewed
Dec 31, 2020
|
|
||
| <h2>Note about Ext4 Filesystems</h2> | ||
| <p>The preceding numbers are for an ext3 file system. Synchronous writes are much slower under <a href="http://en.wikipedia.org/wiki/Ext4">ext4</a> (LevelDB drops to ~31 writes / second and TreeDB drops to ~5 writes / second; SQLite3's synchronous writes do not noticeably drop) due to ext4's different handling of <span class="code">fsync</span> / <span class="code">msync</span> calls. Even LevelDB's asynchronous write performance drops somewhat since it spreads its storage across multiple files and issues <span class="code">fsync</span> calls when switching to a new file.</p> | ||
| <p>The preceding numbers are for an ext3 file system. Synchronous writes are much slower under <a href="https://en.wikipedia.org/wiki/Ext4">ext4</a> (LevelDB drops to ~31 writes / second and TreeDB drops to ~5 writes / second; SQLite3's synchronous writes do not noticeably drop) due to ext4's different handling of <span class="code">fsync</span> / <span class="code">msync</span> calls. Even LevelDB's asynchronous write performance drops somewhat since it spreads its storage across multiple files and issues <span class="code">fsync</span> calls when switching to a new file.</p> |
Contributor
|
Concept ACK, but please squash the commits and remove the changes to the following files/directories:
Thanks for addressing this! :) |
Contributor
|
Concept ACK |
Member
|
Thanks for your contribution. However to move things along I'm going to fix this up and consolidate it with some other changes. Your commit will still be attributed to you. |
maflcko
pushed a commit
that referenced
this pull request
Jan 5, 2021
1112035 doc: fix various typos (Ikko Ashimine) e864084 doc: Use https URLs where possible (Sawyer Billings) Pull request description: Consolidates / fixes the changes from #20762, #20836, #20810. There is no output when `test/lint/lint-all.sh` is run. Closes #20807. ACKs for top commit: MarcoFalke: ACK 1112035 Tree-SHA512: 22ca824688758281a74e5ebc6a84a358142351434e34c88c6b36045d2d241ab95fd0958565fd2060f98317e62e683323b5320cc7ec13592bf340e6922294ed78
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #20807 - updating URLs from HTTP to HTTPS where necessary. Due to the age of the Bitcoin codebase there are a number of legacy URLs with
http://that supporthttps://- I used a script to locate all of them and then visited each one to ensure they are available behind a secure domain. A copy of the script I used can be found on the issue #20807