p2p: remove unused legacyWhitelisted in AcceptConnection() #20791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Curious that I didn't see this before. It's very late but will look at the context tomorrow how this became orphaned. |
jonatack
changed the title
Member
Member
Author
|
Ah, it's from b1a936d |
Member
Author
|
Thanks @glozow! Looks like we arrived at the same source in different ways. |
Contributor
|
ack 8f9ca31 |
Member
|
Looks like gcc is required to get this warning. Using |
Member
|
review ACK 8f9ca31 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 29, 2020
…nnection() 8f9ca31 p2p: remove unused legacyWhitelisted variable (Jon Atack) Pull request description: Noticed while compiling master: ``` net.cpp: In member function ‘void CConnman::AcceptConnection(const CConnman::ListenSocket&)’: net.cpp:1041:10: warning: variable ‘legacyWhitelisted’ set but not used [-Wunused-but-set-variable] 1041 | bool legacyWhitelisted = false; | ^~~~~~~~~~~~~~~~~ ``` ACKs for top commit: glozow: utACK bitcoin@8f9ca31 MarcoFalke: review ACK 8f9ca31 Tree-SHA512: e3fb94d3d34b364b063a115ef9ed06cfd58729a790ba6ed27c7c32430fabf3ca0aa61bc6d33a1236bff802302779c8db28af351208f06c09ad12ce4873c244a6
Contributor
|
Post merge ACK: thanks for cleaning up! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while compiling master: