net: [refactor] Prefer integral types in CNodeStats #20786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This was referenced Dec 28, 2020
Contributor
|
Concept ACK |
maflcko
force-pushed
the
2012-net
branch
4 times, most recently
from
7f126f2 to
6e7e053
Compare
Contributor
|
Concept ACK. |
|
Rebased ok. |
promag
approved these changes
Jan 2, 2021
Member
Author
|
Rebased due to trivial conflict in adjacent line |
jonatack
reviewed
Jan 7, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 8, 2021
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jan 28, 2021
Github-Pull: bitcoin#20786 Rebased-From: faecb74 (partial)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, strings are stored for what are actually integral (strong) enum types. This is fine, because the strings are only used as-is for the debug log and RPC. However, it complicates using them in the GUI. User facing strings in the GUI should be translated and only string literals can be picked up for translation, not runtime
std::strings.Fix that by removing the
std::stringmembers and replace them by strong enum integral types.