Skip to content

Conversation

@pstratem
Copy link
Contributor

This removes the threadpools from test/fuzz/test_runner.py.

Each thread just spawns a subprocess, there's no reason to have both a thread and subprocess.

@pstratem pstratem force-pushed the 2020-12-22-fuzz-test-runner branch from c61fead to ea36284 Compare December 23, 2020 05:16
@maflcko
Copy link
Member

maflcko commented Dec 23, 2020

This needs a bit more code, so absent any performance speedup, I'd prefer the previous version. My assumption was that the fuzzing happens in the subprocess, so any python GIL "deadlocks" in the thread pool won't have any performance effect on the subprocess itself. I might be wrong, though.

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@DrahtBot
Copy link
Contributor

There hasn't been much activity lately and the patch still needs rebase. What is the status here?
  • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
  • Is it no longer relevant? ➡️ Please close.
  • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

@maflcko maflcko closed this Mar 22, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants