-
Notifications
You must be signed in to change notification settings - Fork 38.7k
fuzz: Hide script_assets_test_minimizer #20663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
requested by @practicalswift in bitcoin-core/qa-assets#30 (comment) |
|
Can be tested by running |
|
Wouldn't it be better to leave it as-is, and just exclude it from being listed, or exclude it test-runner.py? That way you don't need to modify the source code in order to use it. |
faa2f9e to
fa857db
Compare
|
Concept ACK: thanks for addressing this! |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
fa857db to
fa0a7a2
Compare
fa0a7a2 to
fa8ed3f
Compare
Can be reviewed with --ignore-all-space
fa8ed3f to
fac726b
Compare
|
cr ACK fac726b: patch looks correct and touches only |
fac726b doc: Fixup docs in fuzz/script_assets_test_minimizer.cpp (MarcoFalke) fafca47 fuzz: Hide script_assets_test_minimizer (MarcoFalke) Pull request description: This is not an actual fuzz target. It is a hack to exploit the built-in capability of fuzz engines to measure coverage. ACKs for top commit: practicalswift: cr ACK fac726b: patch looks correct and touches only `src/test/fuzz/` Tree-SHA512: 0652dd8d9e95746b0906be4044467435d8204a34a30366ae9bdb75b9cb0788d429db7cedf2760fd543565d9d4f7ee206873ed10a29dd715a792a26337f65b53c
This is not an actual fuzz target. It is a hack to exploit the built-in capability of fuzz engines to measure coverage.