[doc] Tidy up Tor doc (more stringent) #20587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to #19638 that left some deprectaed "hidden service/server" naming occurences. It also shall make the chapter titles regarding creation of onion services stringent and easy to read and distinguish. It removes the one and only reference to the testnet (here the testnet onion service port), as it is not explained that it references to the testnet and I do not know why it is mentioned there. It is only confusing. Also, as said, the testnet is not referenced at any other place in this document.
Contributor
|
🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file. |
Contributor
|
ACK 32045bb Weird that we were suggesting that users should open up port 18334 (in addition to 8334). Glad to see that addressed :) |
RiccardoMasutti
approved these changes
Dec 10, 2020
Contributor
RiccardoMasutti
left a comment
RiccardoMasutti
left a comment
There was a problem hiding this comment.
ACK 32045bb
Thanks, it was an oversight
Member
|
Review ACK 32045bb |
laanwj
reviewed
Dec 10, 2020
|
|
||
| HiddenServiceDir /var/lib/tor/bitcoin-service/ | ||
| HiddenServicePort 8333 127.0.0.1:8334 | ||
| HiddenServicePort 18333 127.0.0.1:18334 |
Member
There was a problem hiding this comment.
Agree re: testnet. if people want to run Tor testnet (or signet) nodes, they tend to be developers who know how to change around the ports here. It's just confusing as it is.
Author
|
Thanks for reviewing, glad I could contribute for the better! 🎉 |
ghost
deleted the
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 10, 2020
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 15, 2022
Summary: core#20757: > doc: update -proxy, -onion and -onlynet info in tor.md > > Improve the description of what these options do with regards to > tor or network traffic. > doc: update/improve automatic tor section of tor.md > doc: update tor.md manual config, move after automatic config core#20587: > [doc] Tidy up Tor doc (more stringent) This is a backport of [[bitcoin/bitcoin#20757 | core#20757]] [2/2] (all the tor.md changes from that PR) and [[bitcoin/bitcoin#20587 | core#20587]] Depends on D11031 Test Plan: proofreading Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D11032
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #19638 that left two deprecated "hidden service/server" naming occurences.
It also shall make the chapter titles regarding creation of onion services stringent and easy to read and distinguish.
It removes the one and only reference to the testnet (here the testnet onion service port), as it is not explained that it references to the testnet and I do not know why it is mentioned there. It is only confusing. Also, as said, the testnet is not referenced at any other place in this document.