Declare de facto const reference variables/member functions as const #20584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
added
Refactoring
and removed
Consensus
Mining
P2P
RPC/REST/ZMQ
Validation
Wallet
labels
jonatack
reviewed
Dec 7, 2020
Contributor
|
🕵️ @sipa has been requested to review this pull request as specified in the REVIEWERS file. |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Dec 19, 2020
theStack
approved these changes
Dec 28, 2020
This was referenced Jan 3, 2021
Contributor
|
ACK 31b136e Don't double negatives? ("Declare de facto const reference variables/member functions as const" -- might be worth updating the PR title at least if you don't need to invalidate acks for some other reason) |
maflcko
changed the title
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 7, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 24, 2022
Summary: This is a backport of [[bitcoin/bitcoin#20584 | core#20584]] Note: in net.h, `InactivityCheck` was already `const`ed in D10874 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D11095
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta: This is the second and final part of the
constrefactoring series (part one: #20581). I promise: no more refactoring PRs from me in a while! :) I'll now go back to focusing on fuzzing/hardening!Changes in this PR:
Awards for finding candidates for the above changes go to:
clang-tidy'sreadability-make-member-function-constcheck (list ofclang-tidychecks)cppcheck'sconstVariablecheck (list ofcppcheckchecks)See #18920 for instructions on how to analyse Bitcoin Core using Clang Static Analysis,
clang-tidyandcppcheck.