build: Check that Homebrew's berkeley-db4 package is actually installed #20563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Tested ACK d3ef947. |
willcl-ark
approved these changes
Dec 4, 2020
Member
willcl-ark
left a comment
willcl-ark
left a comment
There was a problem hiding this comment.
tACK d3ef947
will in bitcoin on 201203-bdb [$?] via 🐍 3.6.12 ➜ ./configure -q --without-gui
configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for BDB wallet support (--without-bdb to disable BDB wallet support)
jonasschnelli
approved these changes
Dec 4, 2020
Contributor
jonasschnelli
left a comment
jonasschnelli
left a comment
There was a problem hiding this comment.
Thanks for the cleanup. This is much nicer.
utACK d3ef947
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 4, 2020
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 10, 2020
Github-Pull: bitcoin#20563 Rebased-From: d3ef947
Member
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master (a0489f3) the
configurescript is not able to determine that Homebrew'sberkeley-db4package is uninstalled. This causes a compile error on macOS.With this PR, and with the uninstalled
berkeley-db4package:Related #20478.