test: Fix intermittent feature_taproot issue #20535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
2011-testTapInt
branch
from
fa28725 to
fa275e1
Compare
Member
Author
Member
|
code review ACK fa275e1 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 7, 2020
fa275e1 test: Fix intermittent feature_taproot issue (MarcoFalke) Pull request description: The nodes might disconnect (e.g. due to "Timeout downloading block" https://cirrus-ci.com/task/5313800947630080?command=ci#L1763) and the test fails to continue. Fix that by reconnecting the nodes. ACKs for top commit: laanwj: code review ACK fa275e1 Tree-SHA512: 2871183c8058d8292c9c4ef56ea3d19d5616ca712ebdaabb6609f8c9cd2e16c9ac2ce26aa1e94b346872b7b6fec56b59af151af83de3a5aa08bed01bfcc7187a
Contributor
|
Concept ACK. I saw many times this issue during CI test. |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jul 29, 2021
Github-Pull: bitcoin#20535 Rebased-From: fa275e1
Member
|
Backported in #22578. |
maflcko
pushed a commit
that referenced
this pull request
Jul 30, 2021
55e941f test: Fix intermittent feature_taproot issue (MarcoFalke) 681f728 ci: Build with --enable-werror by default, and document exceptions (Hennadii Stepanov) 89426c4 ci: Fix macOS brew install command (Hennadii Stepanov) Pull request description: This backports a few changes to fix CI failures we are seeing with the 0.21 branch. Backports #21663, this might be the easiest way to fix the macOS CI failures we're seeing. i.e in #22569. The underlying issue is that the older CI images are using a version of brew that without running `brew update` first, is trying to download packages like Boost, from bintray (which no-longer works). This also includes #20182, as by fixing macOS failure, via running `brew upgrade`, we end up using a newer version of miniupnpc, which emits a GNU extension related warning, and causes the build to fail, because we use `-Werror`. Backporting #20535 should fix #22581. ACKs for top commit: hebasto: ACK 55e941f, I verified changes by backporting locally. Tree-SHA512: 3ab2c5c73c707d0f5b862264f3a0179cdeee30ae55aae872f3c3e0bb81d71a5027c39ba830210c99a21f98cc86c4167c4f215e24d1a8891ec79ce512debf82df
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nodes might disconnect (e.g. due to "Timeout downloading block" https://cirrus-ci.com/task/5313800947630080?command=ci#L1763) and the test fails to continue.
Fix that by reconnecting the nodes.