CI msvc: only build vcpkg dependencies for release (not debug) to reduce build times #20489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge introduced in bitcoin#19960. It re-applies a setting to inform vcpkg to only build release vesions of the dependencies rather than the default of debug and release. It had been expected that the vcpkg manifest mechanism introduced in bitcoin#19960 would do this automatically but it turns out not to be the case.
Member
You mean the partial change reversing, right? |
Contributor
Author
Yes. The vcpkg manifest mechanism stays (from what I can tell it's the way of the future for vcpkg) but a previous tweak to adjust the vcpkg settings is being put back. |
Member
|
ACK fa18e7c if green |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 25, 2020
…se (not debug) to reduce build times fa18e7c This change to the appveyor CI config for msvc builds reverses a change introduced in bitcoin#19960. It re-applies a setting to inform vcpkg to only build release vesions of the dependencies rather than the default of debug and release. (Aaron Clauson) Pull request description: This change to the appveyor CI config for msvc builds reverses a change introduced in bitcoin#19960. It re-applies a setting to inform vcpkg to only build release versions of the dependencies rather than the default of debug and release. It had been expected that the vcpkg manifest mechanism introduced in bitcoin#19960 would do this automatically but it turns out not to be the case. ACKs for top commit: MarcoFalke: ACK fa18e7c if green hebasto: ACK fa18e7c, AppVeyor build takes 5 minutes less. Tree-SHA512: 427e7e78190c20e0d85dad9b29beed2b6fa13f99c6bc72bcc1839dfb51237a7cc785ab707b4f851c527c1bb0d3e7ebad9e640969e19d29778584bbaeec75cecf
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 16, 2020
…ge introduced in bitcoin#19960. It re-applies a setting to inform vcpkg to only build release vesions of the dependencies rather than the default of debug and release. It had been expected that the vcpkg manifest mechanism introduced in bitcoin#19960 would do this automatically but it turns out not to be the case. Github-Pull: bitcoin#20489 Rebased-From: fa18e7c
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Dec 16, 2020
…ge introduced in bitcoin#19960. It re-applies a setting to inform vcpkg to only build release vesions of the dependencies rather than the default of debug and release. It had been expected that the vcpkg manifest mechanism introduced in bitcoin#19960 would do this automatically but it turns out not to be the case. Github-Pull: bitcoin#20489 Rebased-From: fa18e7c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to the appveyor CI config for msvc builds reverses a change introduced in #19960. It re-applies a setting to inform vcpkg to only build release versions of the dependencies rather than the default of debug and release.
It had been expected that the vcpkg manifest mechanism introduced in #19960 would do this automatically but it turns out not to be the case.