Replace boost::variant with std::variant #20480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
2011-noBoostVariant
branch
from
fabb2ab to
faccd6d
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Concept ACK |
This was referenced Nov 24, 2020
Closed
Closed
maflcko
force-pushed
the
2011-noBoostVariant
branch
from
faccd6d to
fa06810
Compare
Contributor
|
Concept ACK :) |
Contributor
|
Concept ACK 🚀 |
Contributor
|
Concept ACK |
1 similar comment
Member
|
Concept ACK |
maflcko
force-pushed
the
2011-noBoostVariant
branch
from
fa06810 to
fa1b3b6
Compare
This was referenced Dec 26, 2020
fjahr
reviewed
Jan 1, 2021
Contributor
fjahr
left a comment
fjahr
left a comment
There was a problem hiding this comment.
Concept ACK
Code looks good, I had started looking into similar changes before I found this.
maflcko
pushed a commit
that referenced
this pull request
Jan 4, 2021
…g.m_fallback fa749fb rpc: Replace boost::variant with std::variant for RPCArg.m_fallback (MarcoFalke) Pull request description: Now that we can use std::variant from the vanilla standard library, drop the third-party boost variant dependency. Patch is split out from #20480. A step-by-step replacement is possible because we don't have our own `Variant` wrapper and the source code specifies `boost::variant` explicitly. I think a step-by-step replacement should be preferred, because it simplifies review. ACKs for top commit: fjahr: re-ACK fa749fb Sjors: re-ACK fa749fb Tree-SHA512: 5e3c12b7d535f73065b4afa8df0a488f78fb25d2234f5ecbf740e624db03a34c35fea100eb7d37e84741721310e6450b7fb4296a2207a7ed1fa24485b3650981
maflcko
force-pushed
the
2011-noBoostVariant
branch
4 times, most recently
from
faad066 to
fa5ab4b
Compare
Member
Author
|
Addressed feedback by @fjahr |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 4, 2021
…r RPCArg.m_fallback fa749fb rpc: Replace boost::variant with std::variant for RPCArg.m_fallback (MarcoFalke) Pull request description: Now that we can use std::variant from the vanilla standard library, drop the third-party boost variant dependency. Patch is split out from bitcoin#20480. A step-by-step replacement is possible because we don't have our own `Variant` wrapper and the source code specifies `boost::variant` explicitly. I think a step-by-step replacement should be preferred, because it simplifies review. ACKs for top commit: fjahr: re-ACK fa749fb Sjors: re-ACK fa749fb Tree-SHA512: 5e3c12b7d535f73065b4afa8df0a488f78fb25d2234f5ecbf740e624db03a34c35fea100eb7d37e84741721310e6450b7fb4296a2207a7ed1fa24485b3650981
fjahr
reviewed
Jan 4, 2021
Contributor
fjahr
left a comment
fjahr
left a comment
There was a problem hiding this comment.
Code review ACK fa5ab4b7e4f609a1309503e3b3c5317ebf81a7e9
Thanks, the simplifications made this very straight forward to review IMO.
maflcko
force-pushed
the
2011-noBoostVariant
branch
from
fa5ab4b to
faa8f68
Compare
Contributor
|
Code review ACK faa8f68 Only changes were sorting of includes and switching of |
fanquake
approved these changes
Jan 11, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 11, 2021
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Feb 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can use std::variant from the vanilla standard library, drop the third-party boost variant dependency