refactor: Treat CDataStream bytes as uint8_t #20464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
2011-dataStream
branch
from
fa75da2 to
fa565eb
Compare
Contributor
|
Concept ACK: nice cleanup (+49 −109)! |
added 2 commits
November 23, 2020 21:19
Also, rename CSerializeData to SerializeData
maflcko
force-pushed
the
2011-dataStream
branch
from
fa565eb to
fa5a769
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
Concept ACK! |
Member
|
There are some more unnecessary (possibly more but I could find these quickly) |
Member
|
Concept ACK |
laanwj
reviewed
Dec 19, 2020
Member
|
Code review ACK apart from the above comment. This PR is straightforward to review. The first commit can be seen separately. |
Contributor
|
Concept ACK -- will review as soon as #20464 (comment) is resolved |
maflcko
force-pushed
the
2011-dataStream
branch
from
fa8dec9 to
fa29272
Compare
theStack
approved these changes
Dec 31, 2020
Member
|
code review ACK fa29272 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 2, 2021
fa29272 Remove redundant MakeUCharSpan wrappers (MarcoFalke) faf4aa2 Remove CDataStream::Init in favor of C++11 member initialization (MarcoFalke) fada14b Treat CDataStream bytes as uint8_t (MarcoFalke) fa8bdb0 refactor: Drop CDataStream constructors in favor of one taking a Span of bytes (MarcoFalke) faa96f8 Remove unused CDataStream methods (MarcoFalke) Pull request description: Using `uint8_t` for raw bytes has a style benefit: * The signedness is clear from reading the code, as it does not depend on the architecture Other clean-ups in this pull include: * Remove unused methods * Constructor is simplified with `Span` * Remove `Init()` member in favor of C++11 member initialization ACKs for top commit: laanwj: code review ACK fa29272 theStack: ACK fa29272 🍾 Tree-SHA512: 931ee28bd99843d7e894b48e90e1187ffb0278677c267044b3c0c255069d9bbd9298ab2e539b1002a30b543d240450eaec718ef4ee95a7fd4be0a295e926343f
blockstreamsatellite
added a commit
to Blockstream/bitcoinsatellite
that referenced
this pull request
Oct 28, 2021
Follow the updates from PR bitcoin#20464. Assume the new SerializeData (former CSerializeData) is now a stream of uint8_t and drop the usage of the GetAndClear() function, which was removed in the referred PR.
blockstreamsatellite
added a commit
to Blockstream/bitcoinsatellite
that referenced
this pull request
Nov 10, 2021
Follow the updates from PR bitcoin#20464. Assume the new SerializeData (former CSerializeData) is now a stream of uint8_t and drop the usage of the GetAndClear() function, which was removed in the referred PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
uint8_tfor raw bytes has a style benefit:Other clean-ups in this pull include:
SpanInit()member in favor of C++11 member initialization