tests: Remove no longer needed UBSan suppression (float divide-by-zero in validation.cpp) #20379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o in validation.cpp)
Member
|
ACK 0ccb3ad |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 13, 2020
… (float divide-by-zero in validation.cpp) 0ccb3ad tests: Remove no longer needed UBSan suppression (float-divide-by-zero in validation.cpp) (practicalswift) Pull request description: Remove no longer needed UBSan suppression. The float divide-by-zero in `validation.cpp` was fixed by instagibbs in ec30a79 (bitcoin#15283). ACKs for top commit: MarcoFalke: ACK 0ccb3ad Tree-SHA512: 89a4f4b7371fa5725d9f801cee7ebbd17523f66017c9acfa813657dcb8d837f42209eff44ce9e5d48296a630bab9599d75f10024a0c7da7defb228f4eae3392a
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 23, 2021
Summary: [[bitcoin/bitcoin#20379 | core#20379]] > Remove no longer needed UBSan suppression. > The float divide-by-zero in validation.cpp was fixed by instagibbs in D8857. The other suppression was removed by [[bitcoin/bitcoin#19630 | core#19630]] after fixing fee estimation code that does not exist in Bitcoin ABC. We can assume that we do not need this suppression, and add it back if needed. This is a backport of [[bitcoin/bitcoin#20379 | core#20379]] Test Plan: With UBSAN: `ninja && ninja check check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D10728
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove no longer needed UBSan suppression.
The float divide-by-zero in
validation.cppwas fixed by instagibbs in ec30a79 (#15283).