Skip to content

rpc, wallet: Expose wallet id in getwalletinfo RPC output #20243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hebasto wants to merge 2 commits into from
Closed

rpc, wallet: Expose wallet id in getwalletinfo RPC output #20243

hebasto wants to merge 2 commits into from

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Oct 26, 2020

Based on #20205.

@maflcko maflcko added this to the 22.0 milestone Oct 26, 2020
@jonatack
Copy link
Member

jonatack commented Oct 26, 2020 •
edited
Loading

Seems useful if an id is added, which is under debate. Can haz test?

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 26, 2020 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

This was referenced Oct 26, 2020
Closed
Merged
Merged
@hebasto hebasto closed this Oct 26, 2020
@hebasto hebasto reopened this Oct 26, 2020
This was referenced Oct 30, 2020
Merged
Merged
achow101 and others added 2 commits November 9, 2020 11:40
@achow101
wallet: Properly support a wallet id
30a02e9 
Adds a unique id for each wallet that is saved in a new "walletid"
record. For compatibility, wallets using BDB will use the BDB generated
id. All other wallets will have a randomly generated id if an id does
not already exist.
@hebasto
rpc, wallet: Expose wallet id in getwalletinfo RPC output
b7eb69c
@hebasto
Copy link
Member Author

hebasto commented Nov 9, 2020

Rebased 17a20b9 -> b7eb69c (pr20243.01 -> pr20243.02).

@luke-jr
Copy link
Member

luke-jr commented Dec 5, 2020

@jonatack BDB wallets already have an id

@DrahtBot DrahtBot mentioned this pull request Feb 17, 2021
Merged
@jonatack
Copy link
Member

jonatack commented Mar 26, 2021

Concept ACK, first skim of the code looks reasonable

@DrahtBot DrahtBot mentioned this pull request May 15, 2021
Merged
@DrahtBot
Copy link
Contributor

DrahtBot commented May 19, 2021

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@hebasto
Copy link
Member Author

hebasto commented May 22, 2021

Waiting for a #20205, and closing for now.

@hebasto hebasto closed this May 22, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs rebase Wallet

Projects

None yet

Milestone

22.0

Development

Successfully merging this pull request may close these issues.

7 participants

@hebasto @jonatack @DrahtBot @luke-jr @fanquake @maflcko @achow101