Skip to content

Conversation

@sipsorcery
Copy link
Contributor

This fixes the appveyor CI job, see #20066.

Currently the job fails because some of the vcpkg dependencies need to install msys2 and the hardcoded mirror in the vcpkg config is down.

Vcpkg commit 76a7e9248fb3c57350b559966dcaa2d52a5e4458 adds new mirrors to the hardcoded list.

This fixes the appveyor CI job, see bitcoin#20066.

Currently the job fails because some of the vcpkg dependencies need to install msys2 and the hardcoded mirror in the vcpkg config is down.

Vcpkg commit 76a7e9248fb3c57350b559966dcaa2d52a5e4458 adds new mirrors to the hardcoded list.
@hebasto
Copy link
Member

hebasto commented Oct 6, 2020

Concept ACK.

@hebasto
Copy link
Member

hebasto commented Oct 6, 2020

For reference: microsoft/vcpkg#13889

@decryp2kanon
Copy link
Contributor

decryp2kanon commented Oct 6, 2020

utACK c83155b

@practicalswift
Copy link
Contributor

ACK c83155b

VCPKG_COMMIT_ID: '40230b8e3f6368dcb398d649331be878ca1e9007' refers to this version of the vcpkg tree: https://github.com/microsoft/vcpkg/tree/40230b8e3f6368dcb398d649331be878ca1e9007

@sipa
Copy link
Member

sipa commented Oct 6, 2020

utACK c83155b. Verified that 40230b8e3f6368dcb398d649331be878ca1e9007 is a recent commit in the https://github.com/microsoft/vcpkg repository's master branch.

@sipa sipa merged commit d8cd7b1 into bitcoin:master Oct 6, 2020
@sipa
Copy link
Member

sipa commented Oct 6, 2020

Merged, and re-enabled AppVeyor webhook.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@decryp2kanon
Copy link
Contributor

decryp2kanon commented Oct 6, 2020

@sipsorcery
Copy link
Contributor Author

You've hit the 1hr limit. The Bitcoin Core appveyor jobs have been granted extra time which is why they work and personal jobs on the free plan don't.

@maflcko
Copy link
Member

maflcko commented Oct 7, 2020

I think they are happy to raise the time even for free projects. Our project used to be free as well, but we subscribed to the 2 build machine plan for OSS a while back.

@decryp2kanon
Copy link
Contributor

You've hit the 1hr limit. The Bitcoin Core appveyor jobs have been granted extra time which is why they work and personal jobs on the free plan don't.

how to get the extra time? i cannot test appveyor in my repo due to 1 hour limitation...

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Oct 16, 2020
This fixes the appveyor CI job, see bitcoin#20066.

Currently the job fails because some of the vcpkg dependencies need to install msys2 and the hardcoded mirror in the vcpkg config is down.

Vcpkg commit 76a7e9248fb3c57350b559966dcaa2d52a5e4458 adds new mirrors to the hardcoded list.

Github-Pull: bitcoin#20095
Rebased-From: c83155b
maflcko pushed a commit that referenced this pull request Dec 2, 2020
9c71499 rpc: Adjust witness-tx deserialize error message (MarcoFalke)
a7bdf5c rpc: Properly deserialize txs with witness before signing (MarcoFalke)
0b64310 Avoid the use of abs64 in timedata (Pieter Wuille)
5b2de04 Bump vcpkg commit ID to get new msys mirror list (Aaron Clauson)
6957419 build: set minimum required Boost to 1.48.0 (fanquake)
27bb2cc util: Don't reference errno when pthread fails. (MIZUTA Takeshi)
8bd2ab1 docs: Correct description for getblockstats's txs field (Nadav Ivgi)
a8411b3 qt: Fix QFileDialog for static builds (Hennadii Stepanov)

Pull request description:

  Backports the following to the 0.19 branch:
  * #19194 - util: Don't reference errno when pthread fails. - not clean.
  * #19536 - qt, build: Fix QFileDialog for static builds
  * #19777 - docs: Correct description for getblockstats's txs field
  * #19836 - rpc: Properly deserialize txs with witness before signing
  * #20095 - CI: Bump vcpkg commit ID to get new msys mirror list
  * #20141 - Avoid the use of abs64 in timedata
  * #20142 - [0.20] build: set minimum required Boost to 1.48.0

ACKs for top commit:
  jnewbery:
    utACK 9c71499
  dergoegge:
    utACK 9c71499
  MarcoFalke:
    ACK 9c71499

Tree-SHA512: 2151f22bc37a6a2f51a8f36c27376622016b51ff99b570e95354356fce1f1761cf19cb4f8ebfa26d38485a0bff6ff6ee834d2798fb383e2ae2abb175548b8fe6
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants