test: Mention commit id in scripted diff error #20069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
approved these changes
Oct 3, 2020
Member
There was a problem hiding this comment.
ACK Concept ACK 3491bf3, should help in situations like https://travis-ci.org/github/bitcoin/bitcoin/jobs/732481553
Member
|
Will all future Travis CI builds fail due to the ill-formed title of the f471a3b commit? |
Member
|
Good idea. |
Member
Author
It's pretty strange, I assumed this script will only check the PR in question, not the whole project history. |
Contributor
Contributor
|
ACK 3491bf3 Without this change, at 54fc96f: With this change (rebased onto 54fc96f): |
Member
|
utACK 3491bf3 |
This was referenced Oct 26, 2020
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Oct 27, 2020
Verifier for scriptable changes Includes changes from the following upstream PRs: - bitcoin/bitcoin#10189 - Excluding the `CNode` scripted changes. - bitcoin/bitcoin#10480 - bitcoin/bitcoin#11390 - bitcoin/bitcoin#13281 - Only the lint scripts we already have. - bitcoin/bitcoin#13454 - Only changes to scripts we already have. - bitcoin/bitcoin#14864 - bitcoin/bitcoin#16327 - Includes some portability fixes to other shell scripts. - bitcoin/bitcoin#20069
barton2526
added a commit
to barton2526/Gridcoin-Research
that referenced
this pull request
Jun 2, 2021
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 24, 2021
3491bf3 test: Mention commit id in scripted diff error (Wladimir J. van der Laan) Pull request description: Add commit id to make spotting the issue easier. ACKs for top commit: robot-dreams: ACK 3491bf3 sipa: utACK 3491bf3 hebasto: ~ACK~ Concept ACK 3491bf3, should help in situations like https://travis-ci.org/github/bitcoin/bitcoin/jobs/732481553 Tree-SHA512: 1ae66fa760f9e5d52e029bae71f6b5863f1efd7b95de3723ea09290944c9d7687f5ec6927aa115a3aebd6f2b993baa0c2433975c6ad5cd2858089013362eb599
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add commit id to make spotting the issue easier.