test: use explicit p2p objects where available #20022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the intent of the tests easier to understand, we reference the p2p connection objects by their explicit names instead of the p2ps array.
Contributor
|
Concept ACK Welcome (again) as a contributor @guggero! :) |
theStack
approved these changes
Sep 26, 2020
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
ACK 0fcaf73
Identified the remaining p2ps[] accesses via git grep "\.p2ps\[" and verified that the tests p2p_getdata.py and wallet_resendwallettransactions.py have explicit p2p objects that can be used instead. The affected tests passed locally. 👌
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 14, 2021
Summary: To make the intent of the tests easier to understand, we reference the p2p connection objects by their explicit names instead of the p2ps array. This is a backport of [[bitcoin/bitcoin#20022 | core#20022]] Test Plan: `test/functional/test_runner.py p2p_getdata wallet_resendwallettransactions` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10343
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up patch to #19804 as suggested by MarcoFalke (#19804 (comment)).
To make the intent of the tests easier to understand, we reference the
p2p connection objects by their explicit names instead of the p2ps array.