refactor: Signet fixups #19993
Merged
refactor: Signet fixups #19993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
@ajtowns suggestions are good, ACK otherwise. |
added 5 commits
September 22, 2020 22:28
m_valid implies the block solution has been checked, which is not the case. It only means the txs could be parsed. C++17 comes with std::optional, so just use that instead.
maflcko
force-pushed
the
2009-signetFixups
branch
from
fadee17 to
facaf9e
Compare
Contributor
|
Code review ACK fadee171c8b0b591daf8f1d65640e4f288b3c3bf |
Contributor
|
ACK facaf9e -- code review only |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 23, 2020
facaf9e doc: Document signet BIP (MarcoFalke) faf0a26 doc: Update comments for new chain settings (-signet and -chain=signet) (MarcoFalke) fae0548 fuzz: Remove needless guard (MarcoFalke) 77771a0 refactor: Remove SignetTxs::m_valid and use optional instead (MarcoFalke) fa2ad5d test: Run signet test even when wallet was not compiled (MarcoFalke) Pull request description: Some doc and test fixups for bitcoin#18267 ACKs for top commit: ajtowns: ACK facaf9e -- code review only dr-orlovsky: Reviewed & ACK bitcoin@facaf9e kallewoof: Code review ACK facaf9e Tree-SHA512: 8085027c488d84bb4bddccba78bd2d4c5af0d8e2644ee72265f1f30fa8c83f61a961d9da2c796f2940e69682291cbee7b1028b6a6ce123ad9134c0ebbf4723b0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some doc and test fixups for #18267