test: Remove or explain syncwithvalidationinterfacequeue #19893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. Coverage
Updated at: 2020-10-23T12:07:36.882496. |
maflcko
force-pushed
the
2009-testSync
branch
from
0000857 to
faffc74
Compare
Member
Author
|
rebased |
Contributor
|
Concept ACK |
This was referenced Sep 27, 2020
added 2 commits
October 8, 2020 14:23
maflcko
commented
Nov 19, 2020
| self.nodes[1].invalidateblock(block_reorg) | ||
| self.sync_blocks() | ||
| self.nodes[0].syncwithvalidationinterfacequeue() | ||
| assert_equal(self.nodes[0].getbalance(minconf=0), 0) # wallet txs not in the mempool are untrusted |
Member
Author
There was a problem hiding this comment.
note that wallet rpc will internally block if the chain tip changes. see BlockUntilSyncedToCurrentChain
Contributor
|
Code review ACK fa6af31 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 6, 2020
…acequeue fa6af31 test: Document why syncwithvalidationinterfacequeue is needed in tests (MarcoFalke) fa135a1 Revert "test: Add missing sync_all to wallet_balance test" (MarcoFalke) Pull request description: syncwithvalidationinterfacequeue is a hidden test-only RPC, so it should not be used when it is not needed. Thus, either remove it or explain why it is needed. ACKs for top commit: fjahr: Code review ACK fa6af31 Tree-SHA512: de30db4ab521184091ee5beeab02989138cf7cf05088f766a2fb106151b239310b63d5380cb79e2a072f72c5ae9513aecae8eb9c1c7be713771585c3cb04d63a
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 26, 2022
Summary: `syncwithvalidationinterfacequeue` is a hidden test-only RPC, so it should not be used when it is not needed. Thus, either remove it or explain why it is needed. > Revert "test: Add missing sync_all to wallet_balance test" > > This reverts commit rABC7a820a75ecfb > > The underlying bug has been fixed in D7511. > test: Document why syncwithvalidationinterfacequeue is needed in tests This is a backport of [[bitcoin/bitcoin#19893 | core#19893]] Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10895
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syncwithvalidationinterfacequeue is a hidden test-only RPC, so it should not be used when it is not needed. Thus, either remove it or explain why it is needed.