doc: Fix getmempoolancestors RPC result doc #19765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Rendered diff: $ git diff --ignore-all-space
diff --git a/getmempoolancestors b/getmempoolancestors
index 1d4e56c..64e6aa1 100644
--- a/getmempoolancestors
+++ b/getmempoolancestors
@@ -14,6 +14,7 @@ Result (for verbose = false):
Result (for verbose = true):
{ (json object)
+ "transactionid" : { (json object)
"vsize" : n, (numeric) virtual transaction size as defined in BIP 141. This is different from actual serialized size for witness transactions as witness data is discounted.
"weight" : n, (numeric) transaction weight as defined in BIP 141.
"fee" : n, (numeric) transaction fee in BTC (DEPRECATED)
@@ -43,6 +44,8 @@ Result (for verbose = true):
],
"bip125-replaceable" : true|false, (boolean) Whether this transaction could be replaced due to BIP125 (replace-by-fee)
"unbroadcast" : true|false (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers)
+ },
+ ...
}
Examples: |
laanwj
changed the title
Member
|
This matches the actual output of the command better. |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 15, 2021
Summary: This is a backport of [[bitcoin/bitcoin#19765 | core#19765]] Test Plan: Run this command before and after the change: ``` src/bitcoin-cli help getmempoolancestors > before.txt ``` Compare: ``` $ git diff --ignore-all-space ~/before.txt ~/after.txt diff --git a/home/pierre/before.txt b/home/pierre/after.txt index b241d3c9e9..343a383459 100644 --- a/home/pierre/before.txt +++ b/home/pierre/after.txt @@ -14,6 +14,7 @@ Result (for verbose = false): Result (for verbose = true): { (json object) + "transactionid" : { (json object) "size" : n, (numeric) transaction size. "fee" : n, (numeric) transaction fee in XEC (DEPRECATED) "modifiedfee" : n, (numeric) transaction fee with fee deltas used for mining priority (DEPRECATED) @@ -40,6 +41,8 @@ Result (for verbose = true): ... ], "unbroadcast" : true|false (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers) + }, + ... } Examples: ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10115
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.