wallet: Avoid multiple BerkeleyBatch in DelAddressBook #19738
Conversation
meshcollider
left a comment
meshcollider
left a comment
There was a problem hiding this comment.
Code review ACK b2ce2b97501f8642b79da024dd485545b67f5533
|
In |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
promag
force-pushed
the
2020-08-deladdressbook
branch
from
b2ce2b9 to
abac436
Compare
Done. Also rebased now that #19289 is merged. |
|
ACK abac436 |
|
|
||
| const CTxOut& CWallet::FindNonChangeParentOutput(const CTransaction& tx, int output) const | ||
| { | ||
| AssertLockHeld(cs_wallet); |
There was a problem hiding this comment.
@achow101 per #19738 (comment) I'm curious why this should be added, as there is already an AssertLockHeld(cs_wallet); at the top of its caller, ListCoins(). For a future call from elsewhere?
There was a problem hiding this comment.
@jonatack I could split to a different commit though to be more correct, just LMK.
There was a problem hiding this comment.
No worries, I was only trying to understand the locking. This is fine.
Summary: This is a backport of [[bitcoin/bitcoin#19738 | core#19738]] Test Plan: With TSAN: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10190
5 participants
No description provided.