wallet: Replace -zapwallettxes with wallet tool command #19700
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK! I think this is the best solution if we decide to not remove the functionality wholesale. |
achow101
force-pushed
the
zapwallettxes-wallettool
branch
3 times, most recently
from
b8742c8 to
5739465
Compare
Contributor
Contributor
|
Concept ACK and light core review ACK 5739465627a5ed9fb8cefa87e1fa026475f602e5. The questions in the past popped up if we have to bump the wallet version (not to mix with the minwalletversion) if we add a key/value type. I don't think so but can remember @luke-jr had some arguments for bumping it. |
If we are keeping metadata, write the zapped txs in zaptx records. Remove them after fetching the metadata.
Removes the startup option and replaces it with an error message telling users to use the RPC instead.
achow101
force-pushed
the
zapwallettxes-wallettool
branch
from
5739465 to
f7604a5
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Aug 20, 2020
Merged
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Member
|
Seems the we have consensus to move forward in #19671, so I'm going to close this PR. |
fanquake
added a commit
that referenced
this pull request
Sep 1, 2020
3340dba Remove -zapwallettxes (Andrew Chow) Pull request description: It's not clear what use there is to keeping `-zapwallettxes` given that it's intended usage has been superseded by `abandontransaction`. So this removes it outright. Alternative to #19700 ACKs for top commit: meshcollider: utACK 3340dba fanquake: ACK 3340dba - remaining manpage references will get cleaned up pre-release. Tree-SHA512: 3e58e1ef6f4f94894d012b93e88baba3fb9c2ad75b8349403f9ce95b80b50b0b4f443cb623cf76c355930db109f491b3442be3aa02972e841450ce52cf545fc8
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 3, 2020
3340dba Remove -zapwallettxes (Andrew Chow) Pull request description: It's not clear what use there is to keeping `-zapwallettxes` given that it's intended usage has been superseded by `abandontransaction`. So this removes it outright. Alternative to bitcoin#19700 ACKs for top commit: meshcollider: utACK 3340dba fanquake: ACK 3340dba - remaining manpage references will get cleaned up pre-release. Tree-SHA512: 3e58e1ef6f4f94894d012b93e88baba3fb9c2ad75b8349403f9ce95b80b50b0b4f443cb623cf76c355930db109f491b3442be3aa02972e841450ce52cf545fc8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
-zapwallettxesstartup option with azapwallettxescommand in the wallet tool.To preserve the transaction metadata, using
zapwallettxesrewrites the transactions as azaptxrecord and removes the originaltxrecord.bestblockis also reset to null to trigger a rescan. On loading the wallet, a rescan will be triggered. If anyzaptxrecords were found, then the metadata from those records is copied to the new tx. Allzaptxrecords are removed after loading. If metadata is not kept (by using-keepmeta=0in the wallet tool), then nozaptxrecords will be created.Lastly
-zapwallettxesis replaced with an error telling users to use the wallet tool command instead.Alternative to #19653 and #19671