build: set minimum required Boost to 1.58.0 #19667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK. Given that no one complained about the compile failure yet (other than me) probably means no one is running on that system. And it is still possible to compile from depends. |
Member
|
Concept ACK. |
Any systems which only have an older install-able Boost can use depends. Fixes: bitcoin#19506
Member
|
For reference, here is the availability of boost in OSes: #16381 (comment) |
Member
|
ACK 70452a0 I wonder if there are more boost version workarounds that can be removed, but couldn't find anything with a naive search for |
Contributor
Contributor
Gitian builds
|
Contributor
|
ACK 70452a0 -- patch looks correct Nice cleanup! |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 6, 2020
70452a0 build: set minimum required Boost to 1.58 (fanquake) Pull request description: Any systems which only have an older installable Boost can use depends. 1.58.0 retains compatibility with the packages [installable on Ubuntu 16.04](https://packages.ubuntu.com/xenial/libboost-dev). The projects usage of Boost wont be going away any time soon, if ever (i.e bitcoin#15382), and our usage of the test framework. Fixes: bitcoin#19506 ACKs for top commit: practicalswift: ACK 70452a0 -- patch looks correct laanwj: ACK 70452a0 hebasto: ACK 70452a0, tested on Linux Mint 20 (x86_64). Tree-SHA512: d290415e3c70a394b3d7659c0480a35b4082bdce8d48b1c64a0025f7ad6e21567b4dc85813869513ad246d27f950706930410587c11c1aa3693ae6245084765c
5 tasks
Member
|
It turned out that before this change the actual minimum supported Boost version was 1.48 rather 1.47. |
barton2526
added a commit
to barton2526/Gridcoin-Research
that referenced
this pull request
Jun 23, 2021
barton2526
added a commit
to barton2526/Gridcoin-Research
that referenced
this pull request
Jun 24, 2021
Ref: bitcoin/bitcoin#19667 Update configure.ac
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 29, 2021
Summary:
This is a 3 commit PR that replaces all uses of `util.(dis)?connect_nodes` with `TestFramework.(dis)?connect_nodes`. This reduces the number of imports by a lot and leave only one single way of doing this operation.
A later scripted-diff commit replaces the majority of uses, which all
follow this pattern:
`(dis)?connect_nodes(self.nodes[a], self.nodes[b]))`
This commit replaces the few "special cases".
This is a backport of [[bitcoin/bitcoin#19667 | core#19667]] [1/3]
bitcoin/bitcoin@be38684
The line touched in rpc_psbt is in a segwit related test that does not exist in Bitcoin ABC.
Test Plan: `ninja check-functional`
Reviewers: #bitcoin_abc, Fabien
Reviewed By: #bitcoin_abc, Fabien
Differential Revision: https://reviews.bitcoinabc.org/D10558
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any systems which only have an older installable Boost can use depends.
1.58.0 retains compatibility with the packages installable on Ubuntu 16.04.
The projects usage of Boost wont be going away any time soon, if ever (i.e #15382), and our usage of the test framework.
Fixes: #19506