Skip to content

[0.20] lint: fix shellcheck URL in CI install #19612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Jul 28, 2020
Merged

[0.20] lint: fix shellcheck URL in CI install #19612

maflcko merged 1 commit into from
Jul 28, 2020
+1 −1

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jul 28, 2020

This is causing the tests to fail for backports i.e #19606. If you look in the Travis logs there, the output is:

You are downloading ShellCheck from an outdated URL!
Please update to the new URL:
https://github.com/koalaman/shellcheck/releases/download/v0.6.0/shellcheck-v0.6.0.linux.x86_64.tar.xz
For more information, see:
https://github.com/koalaman/shellcheck/issues/1871
PS: Sorry for breaking your build. The hosting costs were getting out of hand :(

@fanquake fanquake requested a review from maflcko July 28, 2020 12:04
@fanquake
[0.20] lint: fix shellcheck URL in CI install
7ee4769 
This is causing the tests to fail for backports etc.
@fanquake fanquake force-pushed the fix_shellcheck_0_20 branch from 349e3f9 to 7ee4769 Compare July 28, 2020 12:13
@maflcko
Copy link
Member

maflcko commented Jul 28, 2020

review ACK 7ee4769

@maflcko maflcko merged commit 6acb21e into bitcoin:0.20 Jul 28, 2020
@fanquake fanquake deleted the fix_shellcheck_0_20 branch July 28, 2020 12:22
@bitcoin bitcoin locked and limited conversation to collaborators Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maflcko maflcko Awaiting requested review from maflcko

Assignees

No one assigned

Labels

Scripts and tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanquake @maflcko