test: fix intermittent failure in p2p_ibd_txrelay #19552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Jul 19, 2020
jonatack
force-pushed
the
fix-intermittent-p2p_ibd_txrelay-failure
branch
2 times, most recently
from
c19310c to
14bb388
Compare
jonatack
commented
Jul 19, 2020
maflcko
reviewed
Jul 19, 2020
jonatack
force-pushed
the
fix-intermittent-p2p_ibd_txrelay-failure
branch
from
14bb388 to
c4fa20a
Compare
jonatack
force-pushed
the
fix-intermittent-p2p_ibd_txrelay-failure
branch
from
c4fa20a to
12410b1
Compare
vasild
approved these changes
Jul 21, 2020
Contributor
vasild
left a comment
vasild
left a comment
There was a problem hiding this comment.
ACK 12410b1
Sporadic test failures are one of the worst things that can happen to a software project.
I tried to reproduce the failure locally, but without success (there you go!). The following passes with and without the patch for me:
./test/functional/test_runner.py $(for i in {1..100} ; do echo p2p_ibd_txrelay.py ; done)Anyway - the patch looks good.
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 2, 2021
…it_until Summary: This is a backport of [[bitcoin/bitcoin#19552 | core#19552]] Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D10018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix these intermittent failures in Travis CI.
At Marco's suggestion, cherry-picked part of #19134 to nicely simplify using
wait_until.