[tests] Remove unnecessary cs_mains in denialofservice_tests #19533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fdf05d resolved some lock inversion warnings in denialofservice_tests, but left in a number of cs_main locks that are unnecessary (introducing lock inversion warnings in future changes).
Contributor
Author
|
This is the first commit from #17479. Pulled into its own PR because it's fine to change separately from the other commits there, and it's caused some conflicts/rebases in that PR so I'd like to get it merged separately. Should be a trivial review. |
Member
|
Concept ACK. |
Contributor
|
ACK f58c4b5. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 18, 2020
…ervice_tests f58c4b5 [tests] Remove unnecessary cs_mains in denialofservice_tests (Matt Corallo) Pull request description: 9fdf05d resolved some lock inversion warnings in denialofservice_tests, but left in a number of cs_main locks that are unnecessary (introducing lock inversion warnings in future changes). ACKs for top commit: promag: ACK f58c4b5. jonatack: ACK f58c4b5 verified the test locks correspond to the locks in net/net_processing, and the debug build is clean/unit tests pass. Tree-SHA512: de2d9b2a8f08081b2ce31e18585e4677b167a11752b797d790c281575d7dfef3587f8be4fc7f8f16771141b6ff0b0145c7488cf30e79256b0043947c67a6182c
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 17, 2021
Summary: 9fdf05d (D3606) resolved some lock inversion warnings in denialofservice_tests, but left in a number of cs_main locks that are unnecessary (introducing lock inversion warnings in future changes). This is a backport of [[bitcoin/bitcoin#19533 | core#19533]] Test Plan: with TSAN: `ninja check` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9689
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 20, 2021
…ervice_tests f58c4b5 [tests] Remove unnecessary cs_mains in denialofservice_tests (Matt Corallo) Pull request description: 9fdf05d resolved some lock inversion warnings in denialofservice_tests, but left in a number of cs_main locks that are unnecessary (introducing lock inversion warnings in future changes). ACKs for top commit: promag: ACK f58c4b5. jonatack: ACK f58c4b5 verified the test locks correspond to the locks in net/net_processing, and the debug build is clean/unit tests pass. Tree-SHA512: de2d9b2a8f08081b2ce31e18585e4677b167a11752b797d790c281575d7dfef3587f8be4fc7f8f16771141b6ff0b0145c7488cf30e79256b0043947c67a6182c
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
…ervice_tests f58c4b5 [tests] Remove unnecessary cs_mains in denialofservice_tests (Matt Corallo) Pull request description: 9fdf05d resolved some lock inversion warnings in denialofservice_tests, but left in a number of cs_main locks that are unnecessary (introducing lock inversion warnings in future changes). ACKs for top commit: promag: ACK f58c4b5. jonatack: ACK f58c4b5 verified the test locks correspond to the locks in net/net_processing, and the debug build is clean/unit tests pass. Tree-SHA512: de2d9b2a8f08081b2ce31e18585e4677b167a11752b797d790c281575d7dfef3587f8be4fc7f8f16771141b6ff0b0145c7488cf30e79256b0043947c67a6182c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9fdf05d resolved some lock
inversion warnings in denialofservice_tests, but left in a number
of cs_main locks that are unnecessary (introducing lock inversion
warnings in future changes).