psbt: Increment input value sum only once per UTXO in decodepsbt #19517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achow101
force-pushed
the
fix-decodepsbt-fee
branch
from
3c43a61 to
7512278
Compare
Member
Contributor
|
Would be nice to have a test for this, too. |
Member
Opened a "Good first issue" for this in #19523. |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jul 15, 2020
Github-Pull: bitcoin#19517 Rebased-From: 7512278
Member
|
Being backported in #19524. |
laanwj
added a commit
that referenced
this pull request
Jul 16, 2020
… once per UTXO in decodepsbt bad9cf8 Increment input value sum only once per UTXO in decodepsbt (Andrew Chow) Pull request description: Github-Pull: #19517 Rebased-From: 7512278 ACKs for top commit: jnewbery: utACK bad9cf8 laanwj: ACK bad9cf8 Tree-SHA512: 543bbe58f2dafc772289708007d72fa61592270f3de083afffb9a56274b03f2ffe8d8d509a93790ceea3a708e1c02b1ad941e23281b3db1f48766c01a930dbd6
backpacker69
referenced
this pull request
in peercoin/peercoin
Sep 8, 2020
Github-Pull: #19517 Rebased-From: 7512278
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Oct 21, 2020
Github-Pull: bitcoin#19517 Rebased-From: 7512278
Platinumwrist
referenced
this pull request
in syscoin/syscoin
Oct 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the UTXO processing of
decodepsbtto extract the relevantCTxOutand handle the input amounts from that. This avoids double counting the input value.Fixes #19516