wallet: Fix typo in comments; Simplify assert #19490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Concept ACK |
Contributor
|
ACK facd7dd Getting rid of tpyos once in a while is good project hygiene :) |
jonatack
reviewed
Jul 11, 2020
Contributor
meshcollider
left a comment
meshcollider
left a comment
There was a problem hiding this comment.
Code review & functional test run ACK facd7dd
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 12, 2020
facd7dd wallet: Fix typo in comments; Simplify assert (MarcoFalke) Pull request description: Follow up to bitcoin#19046 (comment) and bitcoin#19046 (comment) ACKs for top commit: practicalswift: ACK facd7dd jonatack: ACK facd7dd hebasto: ACK facd7dd, spelling verified with `test/lint/lint-spelling.sh`: all remaining warnings are false positive. Tree-SHA512: 2b185d138058840db56726bb6bcc42e5288a954e2a410c49e04806a047fbbdaf0bb2decc70ecf7613c69caa766655705ca44151613e7ea5015b386d1e726d870
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 31, 2021
Summary: This is a backport of [[bitcoin/bitcoin#19490 | core#19490]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D9992
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #19046 (comment) and #19046 (comment)