test: Add BerkeleyDatabase tsan suppression #19226
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Shouldn't "BerkeleyDatabase" be "BerkeleyBatch" in this case? :) |
Member
Author
|
Any symbol in any backtrace can be used to suppress. A race has at least two backtraces for conflicting read/writes. |
practicalswift
approved these changes
Jun 10, 2020
Contributor
practicalswift
left a comment
practicalswift
left a comment
There was a problem hiding this comment.
ACK fa7b46c -- patch looks correct
Member
|
ACK fa7b46c |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 10, 2020
fa7b46c test: Add BerkeleyDatabase tsan suppression (MarcoFalke) Pull request description: Suppresses/Fixes bitcoin#19211 for now ACKs for top commit: laanwj: ACK fa7b46c practicalswift: ACK fa7b46c -- patch looks correct Tree-SHA512: 749e606caf0f140c1a190e3273ff81d220daa3eb004ba2b2078e6b3c5b6ac196bd5fc91ef42841412cfd4fe1e2a8694fc2a28268fde8485db90076593fc51dc7
maflcko
pushed a commit
that referenced
this pull request
Jul 17, 2020
0cdf2a7 ci: add tsan debug symbols option (Russell Yanofsky) 9a2f126 ci: Add tsan suppression for race in DatabaseBatch (Hennadii Stepanov) Pull request description: Since #19325 was merged, the corresponding change in TSan suppression file gets required. This PR is: - an analogous to #19226 and #19450, and - a temporary workaround for CI fail like https://cirrus-ci.com/task/5741795508224000?command=ci#L4993 ACKs for top commit: MarcoFalke: ACK 0cdf2a7 Tree-SHA512: 7832f143887c8a0df99dea03e00694621710378fbe923e3592185fcd3658546a590693b513abffc5ab96e9ef76c9c4bff3330eeee69a0c5dbe7574f34c417220
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 26, 2021
Summary: I noticed an occasional failure when running the wallet_multiwallet.py functional test using TSAN with clang-12. This is a backport of [[bitcoin/bitcoin#19226 | core#19226]] Test Plan: With TSAN: ``` TSAN_OPTIONS=suppressions=/home/pierre/dev/bitcoin-abc/test/sanitizer_suppressions/tsan test/functional/test_runner.py wallet_multi* ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10544
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppresses/Fixes #19211 for now