qt: Deduplicate NumConnections enum #19193
Closed
+13
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
changed the title
Contributor
|
Concept ACK: DRY is good |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Member
|
Not sure about this architecturally, is the GUI allowed to use arbitrary core types, just like that? Or do they need to be moved to the interface header then? |
This was referenced Aug 21, 2020
Member
Author
|
Closed in favor of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two identical
NumConnectionsenums in the code base:enum NumConnectionsinqt/clientmodel.hwas introduced in [Qt] show number of in/out connections in GUI debug console #3685enum CConnman::NumConnectionsinnet.hwas introduced in p2p: Begin encapsulation #8085This PR drops the former enum in favor of the latter one.