test: Do not swallow flake8 exit code #19172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh, very nice catch! Thanks for fixing. ACK eff770f -- patch looks correct |
maflcko
reviewed
Jun 5, 2020
Member
Author
|
Updated eff770f -> 5d77549 (pr19172.01 -> pr19172.02, diff):
|
Member
|
Approach ACK 5d77549, fine with me |
Contributor
|
ACK 5d77549 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #18210 the
flake8exit code intest/lint/lint-python.shjust not used that makes the linter broken.This PR:
flake8andmypyinto thetest/lint/lint-python.shexit codemypyas the test dependency