cli: display multiwallet total balance in -getinfo #19092

jonatack · 2020-05-28T16:45:44Z

Per review suggestion in #18594 (comment), this PR adds a total_balance field for -getinfo in multiwallet mode.

  "balances": {
    "": 0.00001000,
    "Encrypted": 0.00003500,
    "day-to-day": 0.00000120,
    "side project": 0.00000094
  },
  "total_balance": 0.00003714
}

Updated help:

$ bitcoin-cli -h | grep -A3 getinfo
  -getinfo
       Get general information from the remote server, including the total
       balance and the balances of each loaded wallet when in
       multiwallet mode. Note that -getinfo is the combined result of
       several RPCs (getnetworkinfo, getblockchaininfo, getwalletinfo,
       getbalances, and in multiwallet mode, listwallets), each with
       potentially different state.

Credit to João Barbosa for the suggestion.

promag · 2020-05-28T17:05:14Z

Concept ACK.

Could update doc?

jonatack · 2020-05-28T19:09:59Z

Thanks @promag. Added a release note update.

promag · 2020-05-28T19:57:32Z

This is --help output

  -getinfo
       Get general information from the remote server. Note that unlike
       server-side RPC calls, the results of -getinfo is the result of
       multiple non-atomic requests. Some entries in the result may
       represent results from different states (e.g. wallet balance may
       be as of a different block from the chain state reported)

nit, I wonder if this should document the result.

DrahtBot · 2020-05-28T21:13:14Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

cli, test, doc: bitcoin-cli -getinfo multiwallet balances follow-ups #19089 (cli, test, doc: bitcoin-cli -getinfo multiwallet balances follow-ups by jonatack)
cli/gui: support "@height" in place of blockhash for getblock on client side #16439 (cli/gui: support "@height" in place of blockhash for getblock on client side by ajtowns)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

jonatack · 2020-05-30T10:59:22Z

I wonder it this should document the result.

Made an attempt at improving it.

vahidjalaliii · 2020-05-30T12:40:03Z

#19089

luke-jr · 2020-06-03T18:05:29Z

"balance" seems to perhaps oversimplify things...

Maybe "total_balance"?

Wiphawee112 · 2020-06-04T07:34:30Z

ฉันจะทราบได้อย่างไร่่่่ะว่ายอดเงินอยุ่ทึ่ใหน ช่วยแนะนำด้วยค่ะ

jonatack · 2020-06-04T07:57:41Z

ฉันจะทราบได้อย่างไร่่่่ะว่ายอดเงินอยุ่ทึ่ใหน ช่วยแนะนำด้วยค่ะ

"I can know exactly what the balance is. Please help."

I'll take that as a Concept ACK :)

jonatack · 2020-06-04T08:00:58Z

"balance" seems to perhaps oversimplify things...

Maybe "total_balance"?

That was my initial thought as well. @promag WDYT?

promag · 2020-06-04T08:13:52Z

Also looks fine to me. I just mentioned balance to keep it backward compatible, but I guess that's not a concern in -cli.

jonatack · 2020-06-04T09:29:02Z

Thanks @luke-jr and @promag, updated to total_balance displayed after the balances and improved the test coverage.

luke-jr · 2020-06-08T03:41:27Z

src/bitcoin-cli.cpp

Can we get these into the libbitcoin_util.a module? I think this is the third copy...

Yes, third one. Agreed, a good follow-up.

Why not in this PR or in a base PR especially considering there aren't ACKs.

I think that refactoring would best be done in a separate PR.

Github-Pull: bitcoin#19092 Rebased-From: d1ae2e5827c977938f602c9647df1a57c575c82c

jonatack · 2020-06-22T17:45:06Z

Closing, there are many open PRs and this has no ACKs. At least this PR was pulled into other Bitcoin implementations, so it will be useful for those users.

Github-Pull: bitcoin#19092 Rebased-From: e0c8c8d5ff798d25bcf4d8785e924f04caef425c

Github-Pull: bitcoin#19092 Rebased-From: f47067cfd54375e9fe115aa50991bdb827665b7a

Github-Pull: bitcoin#19092 Rebased-From: fca89dcaee6e6e0194968870550adbf623b8786c

Github-Pull: bitcoin#19092 Rebased-From: d1ae2e5827c977938f602c9647df1a57c575c82c

Github-Pull: bitcoin#19092 Rebased-From: bbf0afa

Github-Pull: bitcoin#19092 Rebased-From: 8e6c8d6

Github-Pull: bitcoin#19092 Rebased-From: 414804e

Github-Pull: bitcoin#19092 Rebased-From: 08ac1ab

DrahtBot added the Tests label May 28, 2020

DrahtBot mentioned this pull request May 28, 2020

cli, test, doc: bitcoin-cli -getinfo multiwallet balances follow-ups #19089

Closed

bitcoin deleted a comment from Wiphawee112 May 29, 2020

jonatack force-pushed the cli-getinfo-multiwallet-total-balance branch from 57f771b to aba6f91 Compare May 30, 2020 11:41

DrahtBot mentioned this pull request Jun 2, 2020

rpc, cli, test: add bitcoin-cli -generate command #19133

Merged

jonatack force-pushed the cli-getinfo-multiwallet-total-balance branch from aba6f91 to c37fab2 Compare June 4, 2020 09:23

jonatack force-pushed the cli-getinfo-multiwallet-total-balance branch 4 times, most recently from fbd14f5 to d1ae2e5 Compare June 6, 2020 16:45

luke-jr reviewed Jun 8, 2020

View reviewed changes

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Jun 14, 2020

cli, doc: update bitcoin-cli -getinfo help

28e479e

Github-Pull: bitcoin#19092 Rebased-From: d1ae2e5827c977938f602c9647df1a57c575c82c

DrahtBot added the Needs rebase label Jun 16, 2020

jonatack force-pushed the cli-getinfo-multiwallet-total-balance branch from d1ae2e5 to 3bed024 Compare June 17, 2020 07:17

DrahtBot added Needs rebase and removed Needs rebase labels Jun 17, 2020

jonatack mentioned this pull request Jun 21, 2020

rpc: remove deprecated CRPCCommand constructor #18531

Merged

jonatack added 6 commits June 21, 2020 18:33

cli: add AmountFromValue() and ValueFromAmount()

bbf0afa

cli: add -getinfo multiwallet total balance

8e6c8d6

test: add assert_scale assertion to test framework

fbccd39

test: add coverage for -getinfo total_balance

414804e

doc: release note for -getinfo total_balance

3b2ab9d

cli, doc: update bitcoin-cli -getinfo help

08ac1ab

jonatack force-pushed the cli-getinfo-multiwallet-total-balance branch from 3bed024 to 08ac1ab Compare June 21, 2020 16:50

DrahtBot removed the Needs rebase label Jun 21, 2020

jonatack closed this Jun 22, 2020

jonatack mentioned this pull request Jun 27, 2020

[Feature] -balanceIndex switch #19392

Closed

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Dec 9, 2020

cli: add AmountFromValue() and ValueFromAmount()

403507d

Github-Pull: bitcoin#19092 Rebased-From: e0c8c8d5ff798d25bcf4d8785e924f04caef425c

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Dec 9, 2020

cli: add -getinfo multiwallet total balance

cd87fec

Github-Pull: bitcoin#19092 Rebased-From: f47067cfd54375e9fe115aa50991bdb827665b7a

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Dec 9, 2020

test: add coverage for -getinfo total_balance

edda2fb

Github-Pull: bitcoin#19092 Rebased-From: fca89dcaee6e6e0194968870550adbf623b8786c

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Dec 9, 2020

cli, doc: update bitcoin-cli -getinfo help

ba0e008

Github-Pull: bitcoin#19092 Rebased-From: d1ae2e5827c977938f602c9647df1a57c575c82c

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 19, 2021

cli: add AmountFromValue() and ValueFromAmount()

cc46c0a

Github-Pull: bitcoin#19092 Rebased-From: bbf0afa

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 19, 2021

cli: add -getinfo multiwallet total balance

e46553f

Github-Pull: bitcoin#19092 Rebased-From: 8e6c8d6

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 19, 2021

test: add coverage for -getinfo total_balance

e612cd8

Github-Pull: bitcoin#19092 Rebased-From: 414804e

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 19, 2021

cli, doc: update bitcoin-cli -getinfo help

e8bab0a

Github-Pull: bitcoin#19092 Rebased-From: 08ac1ab

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

cli: display multiwallet total balance in -getinfo #19092

cli: display multiwallet total balance in -getinfo #19092

Uh oh!

Conversation

jonatack commented May 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag commented May 28, 2020

Uh oh!

jonatack commented May 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag commented May 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented May 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

jonatack commented May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vahidjalaliii commented May 30, 2020

Uh oh!

luke-jr commented Jun 3, 2020

Uh oh!

Wiphawee112 commented Jun 4, 2020

Uh oh!

jonatack commented Jun 4, 2020

Uh oh!

jonatack commented Jun 4, 2020

Uh oh!

promag commented Jun 4, 2020

Uh oh!

jonatack commented Jun 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luke-jr Jun 8, 2020

Choose a reason for hiding this comment

Uh oh!

jonatack Jun 8, 2020

Choose a reason for hiding this comment

Uh oh!

promag Jun 8, 2020

Choose a reason for hiding this comment

Uh oh!

jonatack Jun 8, 2020

Choose a reason for hiding this comment

Uh oh!

jonatack commented Jun 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jonatack commented May 28, 2020 •

edited

Loading

jonatack commented May 28, 2020 •

edited

Loading

promag commented May 28, 2020 •

edited

Loading

DrahtBot commented May 28, 2020 •

edited

Loading

jonatack commented May 30, 2020 •

edited

Loading

jonatack commented Jun 4, 2020 •

edited

Loading