tests: Add fuzzing harness for CNode #19067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
practicalswift
force-pushed
the
fuzzers-2020-05-25
branch
from
c50dee8 to
7960082
Compare
practicalswift
commented
May 25, 2020
Contributor
|
Concept ACK |
practicalswift
force-pushed
the
fuzzers-2020-05-25
branch
from
7960082 to
0869918
Compare
maflcko
reviewed
May 26, 2020
practicalswift
force-pushed
the
fuzzers-2020-05-25
branch
3 times, most recently
from
1e35710 to
2206f16
Compare
Contributor
Author
|
Anything left to do here? :) The changes are limited to |
Contributor
maflcko
reviewed
Jul 14, 2020
practicalswift
force-pushed
the
fuzzers-2020-05-25
branch
from
2206f16 to
a22b42e
Compare
Contributor
Author
|
@Crypt-iQ Thanks for reporting. Should be fixed now. Would you mind retrying? :) |
Contributor
|
@practicalswift Fuzzing with clang-10 libfuzzer. afl-gcc/g++ can also build on a22b42e. |
Crypt-iQ
reviewed
Jul 19, 2020
Contributor
There was a problem hiding this comment.
30 hour fuzzing coverage for this harness (libfuzzer --with-sanitizers=address,fuzzer,undefined): https://crypt-iq.github.io/cnode_cov/src/index.html
Just minor comments from me. Two more functions could be fuzzed:
bool IsPeerAddrLocalGood(CNode *pnode)void AdvertiseLocal(CNode *pnode)
Contributor
|
Tested ACK a22b42e |
Contributor
Author
|
Ready for merge? |
Member
|
needs rebase |
maflcko
reviewed
Aug 27, 2020
practicalswift
force-pushed
the
fuzzers-2020-05-25
branch
from
a22b42e to
cc26fab
Compare
Contributor
Author
|
@jb55 @Crypt-iQ @MarcoFalke Thanks a lot for reviewing. Now rebased. Please re-review :) |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 28, 2020
cc26fab tests: Add fuzzing harness for CNode (practicalswift) Pull request description: Add fuzzing harness for `CNode`. See [`doc/fuzzing.md`](https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md) for information on how to fuzz Bitcoin Core. Don't forget to contribute any coverage increasing inputs you find to the [Bitcoin Core fuzzing corpus repo](https://github.com/bitcoin-core/qa-assets). Happy fuzzing :) Top commit has no ACKs. Tree-SHA512: e6330e5de5b2eb44d3bd91a885e69ebb625bfd1cb2499338aeb3997ff0268848434e651126fe68a8cadd7235c391e61a40d6408ee26e457faf73572e0c375f6b
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 9, 2021
Summary: Backport of core [[bitcoin/bitcoin#19067 | PR19067]]. Depends on D9192. Test Plan: ninja bitcoin-fuzzers ./src/test/fuzz/net <path_to_corpus> Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9193
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fuzzing harness for
CNode.See
doc/fuzzing.mdfor information on how to fuzz Bitcoin Core. Don't forget to contribute any coverage increasing inputs you find to the Bitcoin Core fuzzing corpus repo.Happy fuzzing :)