-
Notifications
You must be signed in to change notification settings - Fork 38.7k
doc: Add link to Visual Studio build readme #19061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maflcko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
hebasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maitrebitcoin
Welcome and thank you for your contribution!
Tested a96fc40f2dc0aa9e319fbe4addee4a9240df805b, clicked the link and it works.
Mind squashing three commits into the one?
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
|
I tried to squash, but I'm not sure this is all OK. |
|
Thanks, however this still needs fixing up. When you are done squashing there should only be a single commit in this PR. |
|
Try something like this |
|
Looks like i managed to do it somehow. |
hebasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1c91ffe, a new link works as expected :)
1c91ffe doc : add link to readme.md in the first section (pad) Pull request description: I have searched how to do it in this doc for some time :-( I think it might help other newbies interested in building with visual studio. ACKs for top commit: hebasto: ACK 1c91ffe, a new link works as expected :) Tree-SHA512: 42ef3ba374bced9b4ab0010fe8c30de06f59ff8a84f8e02f8a91f33e7e403cf91d624fc7df3f45096df53171a90b9ff60277969cc30f1357d92094ad72ca9d53
I have searched how to do it in this doc for some time :-(
I think it might help other newbies interested in building with visual studio.