Skip to content

Conversation

@maitrebitcoin
Copy link
Contributor

I have searched how to do it in this doc for some time :-(
I think it might help other newbies interested in building with visual studio.

@fanquake fanquake added the Docs label May 24, 2020
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maitrebitcoin
Welcome and thank you for your contribution!

Tested a96fc40f2dc0aa9e319fbe4addee4a9240df805b, clicked the link and it works.

Mind squashing three commits into the one?

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

@maitrebitcoin
Copy link
Contributor Author

I tried to squash, but I'm not sure this is all OK.

@fanquake
Copy link
Member

Thanks, however this still needs fixing up. When you are done squashing there should only be a single commit in this PR.

@maflcko
Copy link
Member

maflcko commented May 26, 2020

Try something like this

git reset --soft core/master
git commit -m 'doc : add link to readme.md in the first section'

@laanwj laanwj changed the title doc: new section on to how to build with visual studio doc: Add link to Visual Studio build readme May 26, 2020
@maitrebitcoin
Copy link
Contributor Author

Looks like i managed to do it somehow.
Thanks for the tips and your patience.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1c91ffe, a new link works as expected :)

@fanquake fanquake merged commit 48e114e into bitcoin:master May 27, 2020
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
1c91ffe doc : add link to readme.md in the first section (pad)

Pull request description:

  I have searched how to do it in this doc for some time :-(
  I think it might help other newbies interested in building with visual studio.

ACKs for top commit:
  hebasto:
    ACK 1c91ffe, a new link works as expected :)

Tree-SHA512: 42ef3ba374bced9b4ab0010fe8c30de06f59ff8a84f8e02f8a91f33e7e403cf91d624fc7df3f45096df53171a90b9ff60277969cc30f1357d92094ad72ca9d53
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants