doc: Add warning for rest interface limitation #19050
Conversation
|
Concept ACK |
|
Concept ACK. As long as libevent lacks a way to set an upper bound to the number of concurrent incoming connections to a port (it |
|
Is this specific to the REST interface, though? I think any HTTP-related functionality in bitcoin core is affected by this, including RPC requests (when submitted through HTTP)? |
That is correct (confirmed with another small test). But it seems like we only got reports from people running into the issue via the REST interface. But maybe they just found the issue with the search and did not bother with the distinction. I added the same comment block at the bottom of the JSON-RPC interface doc. Do any other or better places come to mind where I should put it? |
glozow
left a comment
glozow
left a comment
There was a problem hiding this comment.
Concept ACK. I'm pretty sure there isn't a good reason to send several hundred requests at once except for not knowing about a more efficient way to get the same information.
|
Pinging the thread. For those that approved of the idea (@MarcoFalke, @glozow, @laanwj), are there any concerns with ACKing this? |
|
FWIW I am watching |
|
Could mention that this is fixed in libevent 2.2 (and later)? |
It isn't fixed by libevent 2.2 automatically. It only adds functionality that allows me then to open a PR that fixes it :) |
|
ACK 5c3eaf9 |
Github-Pull: bitcoin#19050 Rebased-From: 5c3eaf9
5c3eaf9 doc: Add warnings for http interfaces limitations (Fabian Jahr) Pull request description: `libevent`, which is used for our rest interface, can use up all of the available file descriptors in a system if too many connections are opened at once. If a new block is connected at the same time and can not be written to disk because there are no file descriptors available, the node crashes. Based on my investigation so far the issue is best solved upstream which means we have to wait for the next release (2.2). In the meantime it would be good if we would warn users of this limitation. See bitcoin#11368 for more background. ACKs for top commit: MarcoFalke: ACK 5c3eaf9 Tree-SHA512: 73914538588477ead19068f5832fdcc8e0eb736e51f73b3aca501c93165e5ad634c2511a3fcffff251adcd3efda23a742b48211ad9d3b2a29cdeac17201d06a1
5c3eaf9 doc: Add warnings for http interfaces limitations (Fabian Jahr) Pull request description: `libevent`, which is used for our rest interface, can use up all of the available file descriptors in a system if too many connections are opened at once. If a new block is connected at the same time and can not be written to disk because there are no file descriptors available, the node crashes. Based on my investigation so far the issue is best solved upstream which means we have to wait for the next release (2.2). In the meantime it would be good if we would warn users of this limitation. See bitcoin#11368 for more background. ACKs for top commit: MarcoFalke: ACK 5c3eaf9 Tree-SHA512: 73914538588477ead19068f5832fdcc8e0eb736e51f73b3aca501c93165e5ad634c2511a3fcffff251adcd3efda23a742b48211ad9d3b2a29cdeac17201d06a1
5c3eaf9 doc: Add warnings for http interfaces limitations (Fabian Jahr) Pull request description: `libevent`, which is used for our rest interface, can use up all of the available file descriptors in a system if too many connections are opened at once. If a new block is connected at the same time and can not be written to disk because there are no file descriptors available, the node crashes. Based on my investigation so far the issue is best solved upstream which means we have to wait for the next release (2.2). In the meantime it would be good if we would warn users of this limitation. See bitcoin#11368 for more background. ACKs for top commit: MarcoFalke: ACK 5c3eaf9 Tree-SHA512: 73914538588477ead19068f5832fdcc8e0eb736e51f73b3aca501c93165e5ad634c2511a3fcffff251adcd3efda23a742b48211ad9d3b2a29cdeac17201d06a1
5c3eaf9 doc: Add warnings for http interfaces limitations (Fabian Jahr) Pull request description: `libevent`, which is used for our rest interface, can use up all of the available file descriptors in a system if too many connections are opened at once. If a new block is connected at the same time and can not be written to disk because there are no file descriptors available, the node crashes. Based on my investigation so far the issue is best solved upstream which means we have to wait for the next release (2.2). In the meantime it would be good if we would warn users of this limitation. See bitcoin#11368 for more background. ACKs for top commit: MarcoFalke: ACK 5c3eaf9 Tree-SHA512: 73914538588477ead19068f5832fdcc8e0eb736e51f73b3aca501c93165e5ad634c2511a3fcffff251adcd3efda23a742b48211ad9d3b2a29cdeac17201d06a1
6 participants
libevent, which is used for our rest interface, can use up all of the available file descriptors in a system if too many connections are opened at once. If a new block is connected at the same time and can not be written to disk because there are no file descriptors available, the node crashes. Based on my investigation so far the issue is best solved upstream which means we have to wait for the next release (2.2). In the meantime it would be good if we would warn users of this limitation.See #11368 for more background.