-
Notifications
You must be signed in to change notification settings - Fork 38.7k
[0.20] Fix GBT: Restore "!segwit" and "csv" to "rules" key #19019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
They have been missing since buried deployments were merged
|
utACK 412d5fe |
|
These commits are missing the |
|
The commit were written before the branch (and are located on top of a common ancestor of master+0.20) , so I think the script doesn't need the metadata. |
|
@fanquake This isn't a backport per se; it's the original branch, exactly the same commits just merged into master. |
|
Appveyor is failing a test because the commit that fixed the error isn't included in this branch. This commit is included in the All tests passed on my local machine when git cherry-picked the commit to this branch. |
|
This is a two-line code fix with a two-line test. The risk of breaking something is low, so I think this can go into final without another rc. Thoughts? |
|
I would strongly prefer not to include any code change (no matter how minor) to the binaries in -final that is not in any rc. |
Original branch merges cleanly (no rebase needed)
See also #17946