Concept ACK. I like how this simplifies things.

As I noted on IRC, all the version information for releases including the RC level is self-contained in configure.ac now. There's no need to peek into git. Releases are built from a tag and every tag needs to have unique major/minor/build/rc numbers anyhow. Furthermore, my make-tag script verifies that these numbers match before making and signing the tag.

There is one time it's useful to look at git during the build process: if someone builds from git source, to be able to see the commit they built from in the program. This is somewhat useful for developers but if it causes too much difficulty and complexity (how many times has then been 'fixed' throughout Bitcoin Core's history?) I'm okay with foregoing it.

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• build: Drop the leading 0 from the version number #20223 (Drop the leading 0 from the version number by achow101)
• multiprocess: Add basic spawn and IPC support #19160 (multiprocess: Add basic spawn and IPC support by ryanofsky)
• Bugfix: Only use git for build info if the repository is actually the right one #18902 (Bugfix: Only use git for build info if the repository is actually the right one by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Concept ACK. Since we're already using ac defines, one less script and one less header looks delicious!

Rebased f04a6b4 -> 9e8a1d0 (pr18980.01 -> pr18980.02) due to the conflict with #18677.

Doesn't this break including the current commit hash when doing actual git builds?

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

Concept ACK

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

Changing my concept ACK to ~0. It's not clear the tradeoff of losing git info from source builds is worth this change, and for some reason that tradeoff isn't mentioned in the PR description.

Otherwise, what is the status of this?