The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• test: Fail wait_until early if connection is lost #19489 (test: Fail wait_until early if connection is lost by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Rebased.

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

Thanks for working on this!

Yes, I agree that hash_stop is something we might consider checking. However, I'm worried that because most of the time calls to getheaders pass a hash_stop value of 0 (to indicate "get as many blocks as possible") rather than a specific block's hash value, replacing the existing logic with a hash_stop check might not actually make the tests more robust.

What do you think?

Hi @Nishikoh - would you mind replying to robot-dream's comment as well as rebasing this?