scripts: security-check.py refactors #18796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
force-pushed
the
security_check_no_more_32bit
branch
2 times, most recently
from
ba9ba60 to
00dd74a
Compare
Contributor
|
Concept ACK |
laanwj
reviewed
Apr 30, 2020
contrib/devtools/security-check.py
Outdated
Member
There was a problem hiding this comment.
- Do we want to print
stderrtostderrmaybe? (in this case, whyPIPEit at all) - I'm not sure
Error opening fileis a good error message here. Might want to print the command that failed with the exit status. - Launching a command and raising an error on non-zero exit status what
subprocess.check_calldoes. This might be good enough instead of defining our own function.
Member
|
ACK otherwise, |
Deduplicate all the subprocess code as mentioned in 18713.
fanquake
force-pushed
the
security_check_no_more_32bit
branch
from
00dd74a to
eacedfb
Compare
Member
|
ACK eacedfb |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_commandto de-duplicate all of the subprocess calls. Mentioned in scripts: Add MACHO stack canary check to security-check.py #18713.