bench: Start nodes with -nodebuglogfile #18759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
fanquake
approved these changes
Apr 25, 2020
Member
fanquake
left a comment
fanquake
left a comment
There was a problem hiding this comment.
ACK fabe44e - This makes some of these benchmarks significantly faster to run. MempoolEviction total runtime is down from ~46s to 11s on my machine:
master
git:(master) src/bench/bench_bitcoin --filter="AssembleBlock|DuplicateInputs|MempoolEviction|WalletBalance.*"
# Benchmark, evals, iterations, total, min, max, median
AssembleBlock, 5, 700, 1.96686, 0.000545187, 0.000587392, 0.000553906
DuplicateInputs, 5, 10, 0.465348, 0.00901881, 0.00985031, 0.00922294
MempoolEviction, 5, 41000, 46.2124, 0.000199084, 0.000236504, 0.000230176
WalletBalanceClean, 5, 8000, 2.51127, 6.08507e-05, 6.4575e-05, 6.30788e-05
WalletBalanceDirty, 5, 2500, 5.0095, 0.000393387, 0.000406474, 0.0004025
WalletBalanceMine, 5, 16000, 2.39288, 2.96132e-05, 3.06867e-05, 2.97721e-05
WalletBalanceWatch, 5, 8000, 2.41476, 5.97531e-05, 6.15939e-05, 6.022e-05PR
git:(18759) src/bench/bench_bitcoin --filter="AssembleBlock|DuplicateInputs|MempoolEviction|WalletBalance.*"
# Benchmark, evals, iterations, total, min, max, median
AssembleBlock, 5, 700, 1.65915, 0.00046895, 0.000478331, 0.000476521
DuplicateInputs, 5, 10, 0.476503, 0.00940829, 0.0096428, 0.00954716
MempoolEviction, 5, 41000, 11.3648, 5.53623e-05, 5.55187e-05, 5.54437e-05
WalletBalanceClean, 5, 8000, 2.37871, 5.91818e-05, 5.97714e-05, 5.94537e-05
WalletBalanceDirty, 5, 2500, 4.63081, 0.000366719, 0.000372863, 0.000370887
WalletBalanceMine, 5, 16000, 2.3634, 2.94e-05, 2.9768e-05, 2.94947e-05
WalletBalanceWatch, 5, 8000, 2.39341, 5.96008e-05, 6.0065e-05, 5.98226e-05
Member
Author
|
Open-Close to re-run ci. See #15847 (comment) |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 29, 2020
fabe44e bench: Start nodes with -nodebuglogfile (MarcoFalke) Pull request description: For benchmarking we don't want to depend on the speed of the disk or the amount of debug logging ACKs for top commit: fanquake: ACK fabe44e - This makes some of these benchmarks significantly faster to run. MempoolEviction total runtime is down from ~46s to 11s on my machine: Tree-SHA512: d99700901650325896b9115d20b84a27042152f46266f595bf7ea1414528c0b346f4e707a12ee8b8ba99c35cf155e645e67971c1b2a679c4e609c400ff8b08ae
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 22, 2021
Summary: For benchmarking we don't want to depend on the speed of the disk or the amount of debug logging This is a backport of Core [[bitcoin/bitcoin#18759 | PR18759]] Depends on D9040. Test Plan: `ninja && src/bench/bitcoin-bench` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D9041
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For benchmarking we don't want to depend on the speed of the disk or the amount of debug logging