test: Fix intermittent error in mempool_reorg #18752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK fae9866 |
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 18, 2020
Summary: > Also speed up tx relay while touching the file anyway. This should fix the intermittent error `AssertionError: Mempool sync timed out:` If it doesn't solve the issue completely, we may also need [[bitcoin/bitcoin#17770 | PR17770]], [[bitcoin/bitcoin#18345 | PR18345]] and [[bitcoin/bitcoin#18704 | PR18704]]. These 3 PRs were previous unsuccesful attempts to solve this issue by Core, maybe they are useless or maybe they are part of the solution. This is a backport of Core [[bitcoin/bitcoin#18752 | PR18752]] Test Plan: `ninja && test/functional/test_runner.py mempool_reorg` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D8436
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Apr 14, 2021
Summary --- This is a backport of bitcoin/bitcoin#18752 > Also speed up tx relay and fix two pep8 errors while touching the file anyway. This should fix issue Bitcoin-ABC#213 Test Plan --- * `test/functional/test_runner.py --failfast -j $(nproc) $(echo {1..32} | sed 's/[^ ]*/mempool_reorg.py/g')`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: https://travis-ci.org/github/bitcoin/bitcoin/jobs/677689899#L4717
Also speed up tx relay and fix two pep8 errors while touching the file anyway.