test: check misbehavior more independently in p2p_filter.py #18726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Contributor
|
Concept ACK -- nit: now with so many small tests for checking the size limits, you could put them all in a new method of the test? |
robot-visions
force-pushed
the
p2p-filter
branch
from
8cf70c4 to
edf2491
Compare
Contributor
Author
|
Good idea, updated! And thanks for the review. |
theStack
approved these changes
Apr 25, 2020
robot-visions
force-pushed
the
p2p-filter
branch
from
edf2491 to
cd543d9
Compare
Contributor
|
re-ACK cd543d9 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 2, 2020
…p_filter.py cd543d9 test: check misbehavior more independently in p2p_filter.py (Danny Lee) Pull request description: This expands on bitcoin#18672 in two ways: - Check positive cases (`filterload` accepted, `filteradd` accepted) in addition to the negative cases added in bitcoin#18672 - Address MarcoFalke 's [suggestion](bitcoin#18672 (comment)) to successfully load a filter before testing `filteradd` ACKs for top commit: theStack: re-ACK bitcoin@cd543d9 Tree-SHA512: f82402f6287ccddf08b38b6432d5e2b2b2ef528802a981d04c24bac459022f732d9090d4849d72d3d1eb2c757161dcb18c4c036b6e11dc80114e9cd49f21c3bd
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 28, 2021
…lter.py Summary: cd543d9193ac1882c1b4a8a84e3ac7356a8b7ce9 test: check misbehavior more independently in p2p_filter.py (Danny Lee) Pull request description: This expands on #18672 in two ways: - Check positive cases (`filterload` accepted, `filteradd` accepted) in addition to the negative cases added in #18672 - Address MarcoFalke 's [suggestion](bitcoin/bitcoin#18672 (comment)) to successfully load a filter before testing `filteradd` --- Backport of Core [[bitcoin/bitcoin#18726 | PR18726]] Test Plan: ninja all check check-functional Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D9092
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on #18672 in two ways:
filterloadaccepted,filteraddaccepted) in addition to the negative cases added in test: add further BIP37 size limit checks to p2p_filter.py #18672filteradd