Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Apr 19, 2020

No description provided.

@maflcko maflcko force-pushed the 2004-testMempoolReorgIntermittentFailureHuntDownIncreaseDebugLogStatements branch from fa77b60 to fac2fc4 Compare April 19, 2020 12:40
@fanquake fanquake added the Tests label Apr 19, 2020
@maflcko
Copy link
Member Author

maflcko commented Apr 19, 2020

@maflcko maflcko merged commit 9ea4d83 into bitcoin:master Apr 21, 2020
@maflcko maflcko deleted the 2004-testMempoolReorgIntermittentFailureHuntDownIncreaseDebugLogStatements branch April 21, 2020 15:23
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 23, 2020
…org intermittent failure

fac2fc4 test: Increase debugging to hunt down mempool_reorg intermittent failure (MarcoFalke)

Pull request description:

Top commit has no ACKs.

Tree-SHA512: 4094b44afaa623e58b69f8d0332e60f0150b9ae2fd8bb265210d85546d887672ab8a3435cd9b086be14f69ab5b17e0f9fae06bd8aec1e7947ca766dd72b577c4
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request Jul 6, 2020
830eadf Solving rpc_fundrawtransaction.py amount rounding issue. (furszy)
6cf9778 ATMP: Do not try to get the inputs in zc tx. (furszy)
38efbb9 sync_blocks: Increase debugging to hunt down mempool_reorg intermittent failure (furszy)
dd7855c sync_blocks: check that peer is connected when calling sync_*. (furszy)
bc7d542 functional tests, sync_blocks only cleanup. (furszy)
1ae04e7 Fix mempool package tracking edge case (Suhas Daftuar)
f4052aa Add test showing bug in mempool packages (furszy)
691749f rpc: Accept scientific notation for monetary amounts in JSON (furszy)
b0f9051 Fix removeForReorg to use MedianTimePast (Suhas Daftuar)
92583c6 Don't call removeForReorg if DisconnectTip fails (Suhas Daftuar)
bb77808 Track coinbase spends in CTxMemPoolEntry (furszy)
f607f18 Change GetPriority calculation. (furszy)
ac3c0f1 Remove default arguments for CTxMemPoolEntry() (furszy)
07eae9f Modify variable names for entry height and priority (furszy)
4356b31 Fix bug in mempool_tests unit test (Alex Morcos)
f35ebe3 removeForReorg calls once-per-disconnect-> once-per-reorg (furszy)
7f5737f Fix comment in removeForReorg (furszy)
8ad82ca Fix removal of time-locked transactions during reorg (furszy)
de74ab3 Move ProcessBlockFound reserveKey to optional. (furszy)

Pull request description:

  More back ports and adaptations over the RPC values parsing and mempool. We need to get closer in this area :) .

  * bitcoin#6379
  * bitcoin#6715
  * bitcoin#6915
  * bitcoin#7007
  * bitcoin#7008
  * bitcoin#12643
  * bitcoin#18474
  * bitcoin#18704

ACKs for top commit:
  Fuzzbawls:
    ACK 830eadf
  random-zebra:
    ACK 830eadf and merging...

Tree-SHA512: 014b31008aaf09ebf838e21da59379a45565df440a77d66a0cd53e824a6d69673d6975d08243a43fb5a7ebd1a35c07d1d07412a87216b42e9d6f17a1c0bc5708
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 18, 2020
Summary:
> Also speed up tx relay while touching the file anyway.

This should fix the intermittent error `AssertionError: Mempool sync timed out:`
If it doesn't solve the issue completely, we may also need [[bitcoin/bitcoin#17770 | PR17770]], [[bitcoin/bitcoin#18345 | PR18345]] and [[bitcoin/bitcoin#18704 | PR18704]]. These 3 PRs were previous unsuccesful attempts to solve this issue by Core, maybe they are useless or maybe they are part of the solution.

This is a backport of Core [[bitcoin/bitcoin#18752 | PR18752]]

Test Plan: `ninja && test/functional/test_runner.py mempool_reorg`

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Subscribers: majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8436
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants