Skip to content

Conversation

@saahilshangle
Copy link
Contributor

@saahilshangle saahilshangle commented Apr 16, 2020

Making the instructions for building Bitcoin Core more clear in the main README.md will reduce confusion between the build_msvc and doc folders.

Fixes #18658

@fanquake fanquake added the Docs label Apr 16, 2020
@laanwj
Copy link
Member

laanwj commented Apr 16, 2020

Concept ACK on adding instructions.
However, INSTALL.md contains a single line: "See doc/build-*.md for instructions on building the various elements of the Bitcoin Core reference implementation of Bitcoin.". Might as well directly include the relevant part 😄

@saahilshangle saahilshangle changed the title doc: Adding hyperlink to INSTALL.md in README.md doc: Adding build instructions in readme.md Apr 16, 2020
@fanquake fanquake changed the title doc: Adding build instructions in readme.md doc: mention build docs in README.md Apr 17, 2020
@fanquake
Copy link
Member

Please squash your commits.

@laanwj
Copy link
Member

laanwj commented Apr 22, 2020

ACK bda62e8

@maflcko maflcko merged commit 6e3fc74 into bitcoin:master Apr 28, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 28, 2020
bda62e8 Adding build instructions to Bitcoin Core, fixes bitcoin#18658 (Saahil Shangle)

Pull request description:

  Making the instructions for building Bitcoin Core more clear in the main `README.md` will reduce confusion between the `build_msvc` and `doc` folders.

ACKs for top commit:
  laanwj:
    ACK bda62e8

Tree-SHA512: ee4c394661eba48d4229e3d1e9ddb67ccb79589429bfa9986cb0242cd615d1f3cc5332063562c1e89c0cdd9ae2e609f61e8bfb209926d8363d35d3da6d94ae9c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why is build_msvc separate from the doc folder?

4 participants